Feature #2517
closed
use libosmocore counters for packet/byte counting (statistics)
Added by dexter over 6 years ago.
Updated almost 6 years ago.
Description
use any of the libosmocore counters, rather than having hand-coded counters. A rate counter would have the benefit that it would come with free CTRL interface access to the counters.
(see also the SGSN/PDP-Context per direction packet and byte counting)
- Status changed from New to In Progress
- % Done changed from 0 to 20
I have replaced state.in_stream.err_ts_counter and state.out_stream.err_ts_counter with libosmocore counters. There are still a couple more counters I think.
We have an approach for libosmocore counters: https://gerrit.osmocom.org/#/c/7396/ but we agreed not to merge it. We will go for rate counters instead that are much better alternative and also have better control interface support.
- % Done changed from 20 to 30
There is now an alternate patch that uses libosmocore rate counters:
https://gerrit.osmocom.org/7555 stats: use libosmocore rate counter for in/out_stream.err_ts_counter
- Status changed from In Progress to Feedback
- Assignee changed from dexter to lynxis
lynxis: How can I retrieve the log from the build failure, I only added the link to the top build to the ticket. In order to pinpoint the problem, I need the logtext form the failure situation.
dexter: I've created a 32bit lxc container to test it.
- Assignee changed from lynxis to dexter
The build problem under OBS was most likely a problem an integer size problem on the 32-bit build. I managed to reproduce the faulure under an 32 bit debian VM and fixed it. Here is the new version of the patch:
https://gerrit.osmocom.org/8086 stats: use libosmocore rate counter for in/out_stream.err_ts_counter
- Status changed from Feedback to In Progress
- % Done changed from 30 to 90
- Status changed from In Progress to Resolved
- % Done changed from 90 to 100
As far as I can see we have now joined all relevant counters inside a rate counter group. Whats left is struct mgcp_conn_rtp.osmux.stats. I would suggest to fix this when osmux support is re-introduced. Until now this would only increase the confusion about osmux.
Also available in: Atom
PDF