Project

General

Profile

Actions

Feature #6313

closed

RFC: drop 'fmtp-extra'?

Added by neels 5 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
12/22/2023
Due date:
% Done:

100%

Spec Reference:

Description

In osmo-mgw, there is this VTY cfg option

sdp audio fmtp-extra .NAME

I cannot find any proper documentation for it, but it seems the intended usage is

sdp audio fmtp-extra a=fmtp:112 octet-align=1

and there is code that adds this "a=fmtp:112 octet-align=1" line to all SDP output.
This code adds complexity:
- parsing the cfg string for the PT nr (112 in above example)
- inserting this fmtp-extra to any other fmtp string that may be defined for that PT nr, and doing so wrongly

I think that we should drop it.

'fmtp-extra' was added in 5ea1bc77a3947f541d576f95e7ecc7249fc65b9b (apparently from openbsc.git history) with commit log:

mgcp: Allow to freely control the a=fmtp line for experiments

In case of AMR one can specify the available codecs out-of-band. Allow
to configure this line statically in the configuration file.

Does this 'fmtp-extra' vty option have any user relevance today?

I'd like to drop that feature and shift all fmtp composition to the MGCP clients, where it belongs.

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)