Feature #6313
closedRFC: drop 'fmtp-extra'?
100%
Description
In osmo-mgw, there is this VTY cfg option
sdp audio fmtp-extra .NAMEI cannot find any proper documentation for it, but it seems the intended usage is
sdp audio fmtp-extra a=fmtp:112 octet-align=1and there is code that adds this "a=fmtp:112 octet-align=1" line to all SDP output.
This code adds complexity:
- parsing the cfg string for the PT nr (112 in above example)
- inserting this fmtp-extra to any other fmtp string that may be defined for that PT nr, and doing so wrongly
I think that we should drop it.
'fmtp-extra' was added in 5ea1bc77a3947f541d576f95e7ecc7249fc65b9b (apparently from openbsc.git history) with commit log:
mgcp: Allow to freely control the a=fmtp line for experiments In case of AMR one can specify the available codecs out-of-band. Allow to configure this line statically in the configuration file.
Does this 'fmtp-extra' vty option have any user relevance today?
I'd like to drop that feature and shift all fmtp composition to the MGCP clients, where it belongs.
Updated by laforge 4 months ago
On Fri, Dec 22, 2023 at 09:53:13AM +0000, pespin wrote:
Hi neels , I can't think of any user known to me who ever used that VTY config.
the question is why did we introduce it in the first place...
lick here: https://osmocom.org/my/account
It was introduced more than a decade ago in:
commit 5ea1bc77a3947f541d576f95e7ecc7249fc65b9b Author: Holger Hans Peter Freyther <holger@moiji-mobile.com> Date: Mon Sep 3 00:07:39 2012 +0200 mgcp: Allow to freely control the a=fmtp line for experiments In case of AMR one can specify the available codecs out-of-band. Allow to configure this line statically in the configuration file.
I personally didn't even know we had that feature.
There's no match if you search on osmocom.org in the redmine, so no user
has ever reported anything about it. The only reference in the sysmocom
internal reference is from 2017 and refers to a customer that has ceased to
exist meanwhile.
So from my POV, we can remove it.
