Project

General

Profile

Feature #3530

merge PRIM_INFO_MEAS into PRIM_PH_DATA and PRIM_TCH

Added by dexter 17 days ago. Updated 17 days ago.

Status:
New
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
09/06/2018
Due date:
% Done:

0%

Estimated time:
Spec Reference:

Description

At the moment measurement indication primitives are handed to the upper layers separately. However, they could also be integrated into the primitives that carry the actual data block to which the measurement belongs. This would make things a lot easier to handle and understand since whenever one gets data from the phy, there must be a measurement report attached to it.

When lookint into l1sap.c we can see that PRIM_INFO_MEAS is sent along in an PRIM_INFO_MEAS. PRIM_INFO_MEAS only carries the measurement indication and the time indication. We may decide to flatten this once the measurement indication is settled.

PRIM_PH_DATA and PRIM_TCH carry data and voice. Thats where we need to integrate the measurement indication.

History

#1 Updated by fixeria 17 days ago

The suggested approach is used in OsmocomBB/L1CTL. Makes sense for me.
But is there any reason/explanation why it was initially implemented in that way?

#2 Updated by laforge 17 days ago

Hi fixeria,

On Thu, Sep 06, 2018 at 05:21:50PM +0000, fixeria [REDMINE] wrote:

But is there any reason/explanation why it was initially implemented in that way?

Only jolly would be able to answer that. I think initially it may not
have been clear if the measurements will be processed burst-by-burst on
osmo-bts-trx. But as osmo-bts-{sysmo,lc15,octphy} process measurements
per block, it made sense to use this a standard for all BTS models.

To my knowledge, the common code on top of L1SAP never supported
per-burst measurement processing.

#3 Updated by fixeria 17 days ago

Hi Harald,

per-burst measurement processing

Actually, osmo-bts-trx also produces per-block (i.e. decoded L2 frame) measurements, not per-burst.
The problem is that such measurements are sent separately from the blocks they belong to...

#4 Updated by laforge 17 days ago

On Fri, Sep 07, 2018 at 08:08:15AM +0000, fixeria [REDMINE] wrote:

per-burst measurement processing

Actually, osmo-bts-trx also produces per-block (i.e. decoded L2 frame) measurements, not per-burst.

yes, I know, it does today. But it may very well have been different in the very early days of osmo-bts,
or at least have been planned differently back then.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)