Project

General

Profile

Bug #2643

release scripts shouldn't tag/sign at the same time as "make release"

Added by laforge 7 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
-
Start date:
11/15/2017
Due date:
% Done:

0%

Estimated time:
Spec Reference:

Description

It has been determined that it is impractical to have the tag in the repo at the same time we do a "make release". We cannot assume that the resulting commit will pass gerrit review/verification, and we cannot assume that no other commits are merged by gerrit first. Having a local tag in your repo that is not on the right commit hash will create all sorts of risks.


Related issues

Related to Cellular Network Infrastructure - Feature #1861: automatize the release processResolved2016-11-28

History

#1 Updated by msuraev 6 months ago

#2 Updated by laforge 4 months ago

  • Assignee changed from msuraev to sysmocom

#3 Updated by laforge 3 months ago

  • Assignee changed from sysmocom to pespin

#4 Updated by pespin about 2 months ago

  • Status changed from New to Feedback
  • Assignee changed from pespin to laforge

From my experience it's not a big issue, and I think we can close/reject this issue.

https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release already explains how to re-create the tag. It is also explained how to undo the tag in case the commit needs to be re-created.

What I personally do:
- I create the new release commit+tag in my local pespin/releas and I submit it to gerrit
- When merged in gerrit, I git checkout master and I open gitk. If the tag shows up attached to the commit, everything's fine and no need to re-create the tag, I just git push origin <TAG>. Otherwise I follow the documentation in the wiki to re-create the tag.

#5 Updated by laforge about 2 months ago

On Fri, May 04, 2018 at 12:01:17PM +0000, pespin [REDMINE] wrote:

From my experience it's not a big issue, and I think we can close/reject this issue.

I'm happy if it works for you.

#6 Updated by laforge about 2 months ago

  • Status changed from Feedback to Closed

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)