Cellular Network Infrastructure » cni-legacy » OpenBSC

On Fri, Jul 15, 2016 at 01:50:19PM +0000, dexter [REDMINE] wrote:

Had a look at it, seems to me that nanobts_attr_bts mostly consists of
fixed length fields, except for the last one (NM_ATT_IPACC_CGI), which
seems to be a TL16V field. nanobts_attr_radio is similar, one TL16V
field at the end. nanobts_attr_nse, nanobts_attr_cell,
nanobts_attr_nsvc0 entirely consists of TL16V fields. This is simple
to fix. Will continue this when there is some spare time.

It doesn't really matter if it's fixed or variable length field. The
point is to simply construct a msgb at runtime using msgb_tlv_put() or
msgb_tl16v_put() or related functions, using the content of our
gsm_network/gsm_bts/gsm_bts_trx/gsm_bts_trx_ts data structures for the
source of the configuration data.

The old static tables should simply disappear at that point.

It might also be a good point to generate / capture some OML messages
with the old code, add some autotest cases for that, and then
introduce the new code. This way we make sure that the changed code
will still generate the exact same messages in the end.

--
- Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ ============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)