Bug #6380
openVTY transcript tests are broken [again]
0%
Description
The master-osmo-hnbgw Jenkins job is broken since Feb 27th.
Error during transcript step 3:
[
OsmoHNBGW# show cs7 config
cs7 instance 0
point-code 0.23.5
asp asp-clnt-msc-0 2905 0 m3ua
local-ip localhost
remote-ip localhost
role asp
sctp-role client
as as-clnt-msc-0 m3ua
asp asp-clnt-msc-0
routing-key 0 0.23.5
]
Error while verifying transcript file './config//defaults.vty'
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/osmopython-0.2.1-py3.11.egg/osmopy/osmo_interact/common.py", line 357, in verify_application
interact.verify_transcript_file(transcript_file)
File "/usr/local/lib/python3.11/dist-packages/osmopython-0.2.1-py3.11.egg/osmopy/osmo_interact/common.py", line 111, in verify_transcript_file
result = self.verify_transcript(content)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/osmopython-0.2.1-py3.11.egg/osmopy/osmo_interact/common.py", line 199, in verify_transcript
raise Exception('Result mismatch:\n%s\n\nExpected:\n[\n%s\n]\n\nGot:\n[\n%s\n%s\n]'
Exception: Result mismatch:
Mismatch:
Expect:
' sctp-role client'
Got:
' transport-role client'
Expected:
[
OsmoHNBGW# show cs7 config
cs7 instance 0
point-code 0.23.5
asp asp-clnt-msc-0 2905 0 m3ua
local-ip localhost
remote-ip localhost
role asp
sctp-role client
as as-clnt-msc-0 m3ua
asp asp-clnt-msc-0
routing-key 0 0.23.5
]
Got:
[
OsmoHNBGW# show cs7 config
cs7 instance 0
point-code 0.23.5
asp asp-clnt-msc-0 2905 0 m3ua
local-ip localhost
remote-ip localhost
role asp
transport-role client
as as-clnt-msc-0 m3ua
asp asp-clnt-msc-0
routing-key 0 0.23.5
]
RESULTS:
FAIL: ./config//defaults.vty
This is a side effect of my patch that has been merged to libosmo-sccp.git:
https://cgit.osmocom.org/libosmo-sccp/commit/?id=4d7e20193c264585080b9edc91eb630dd005e396
commit 4d7e20193c264585080b9edc91eb630dd005e396
Author: Vadim Yanitskiy <vyanitskiy@sysmocom.de>
Date: Thu Feb 15 05:29:14 2024 +0700
VTY: rename 'sctp-role' to 'transport-role', add an alias
Updated by fixeria about 2 months ago
- Assignee deleted (
fixeria) - Priority changed from High to Normal
This has already happened before:
https://cgit.osmocom.org/osmo-hnbgw/commit/?id=d6b0217c338eb70252e87bfeceb398bdb3b80c7a
commit d6b0217c338eb70252e87bfeceb398bdb3b80c7a
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: Thu Jun 8 19:14:45 2023 +0200
tests: Update *.vty after libosmo-sccp VTY improvements
The problem here is that, for whatever reason, osmo-hnbgw.git implements testing coverage for VTY commands provided by libosmo-sccp.git (which has its own VTY transcript tests). This looks wrong to me, because there is always a possibility that we add new parameters to libosmo-sccp.git and end up with broken tests in osmo-hnbgw.git again. Ideally, the VTY transcripts should cover only the project-local VTY commands. I believe we want to avoid this in the future and stop testing commands provided by external libraries?
Updated by fixeria about 2 months ago
This patch (by laforge) is fixing the output of 'show running-config':
https://gerrit.osmocom.org/c/libosmo-sccp/+/36114
However the fundamental problem of testing external VTY commands and their output remains.
