Osmocom Libraries » libosmo-abis

This appears to be a regression of recent libosmo-abis.git commit:

commit a87de3cd60d447c5199194ae8fa44335198de9c9
Author: Harald Welte <laforge@osmocom.org>
Date:   Wed Feb 21 17:41:12 2024 +0100

    input/ipaccess: Always log with context, if we have any

specifically, the following part of this commit:

@@ -920,13 +894,13 @@ int ipaccess_bts_handle_ccm(struct ipa_client_conn *link,
                        if (link->ofd->priv_nr >= E1INP_SIGN_RSL)
                                trx_nr = link->ofd->priv_nr - E1INP_SIGN_RSL;

-                       LOGP(DLINP, LOGL_NOTICE, "received ID_GET for unit ID %u/%u/%u\n",
-                            dev->site_id, dev->bts_id, trx_nr);
+                       LOGPIL(line, DLINP, LOGL_NOTICE, "received ID_GET for unit ID %u/%u/%u\n",
+                              dev->site_id, dev->bts_id, trx_nr);
                        rmsg = ipa_bts_id_resp(dev, data + 1, len - 1, trx_nr);
                        ret = ipa_send(link->ofd->fd, rmsg->data, rmsg->len);
                        if (ret != rmsg->len) {
-                               LOGP(DLINP, LOGL_ERROR, "cannot send ID_RESP " 
-                                    "message. Reason: %s\n", strerror(errno));
+                               LOGPIL(line, DLINP, LOGL_ERROR, "cannot send ID_RESP message. Reason: %s\n",
+                                      strerror(errno));
                                goto err_rmsg;
                        }
                        msgb_free(rmsg);
@@ -935,8 +909,8 @@ int ipaccess_bts_handle_ccm(struct ipa_client_conn *link,
                        rmsg = ipa_bts_id_ack();
                        ret = ipa_send(link->ofd->fd, rmsg->data, rmsg->len);
                        if (ret != rmsg->len) {
-                               LOGP(DLINP, LOGL_ERROR, "cannot send ID_ACK " 
-                                    "message. Reason: %s\n", strerror(errno));
+                               LOGPIL(line, DLINP, LOGL_ERROR, "cannot send ID_ACK message. Reason: %s\n",
+                                      strerror(errno));
                                goto err_rmsg;
                        }
                        msgb_free(rmsg);

The problem is that line is NULL and LOGPIL is dereferencing it unconditionally:

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7c02274 in ipaccess_bts_handle_ccm (link=link@entry=0x55555584bef0, dev=0x55555584a920, msg=msg@entry=0x55555588f7f0) at ../../../src/libosmo-abis/src/input/ipaccess.c:897
897                             LOGPIL(line, DLINP, LOGL_NOTICE, "received ID_GET for unit ID %u/%u/%u\n",
(gdb) p line
$1 = (struct e1inp_line *) 0x0

Here is a partial revert, which fixes ttcn3-msc-test:

https://gerrit.osmocom.org/c/libosmo-abis/+/36100 input/ipaccess: fix regression in ipaccess_bts_handle_ccm() [NEW]

I am currently testing ttcn3-sgsn-test.

fixeria wrote in #note-2:

I am currently testing ttcn3-sgsn-test.

The patch also fixes ttcn3-sgsn-test. Waiting for code review.

The patch has been merged.

• ttcn3-msc-test is back to normal: https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-msc-test/2313/
• ttcn3-sgsn-test is back to normal: https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-sgsn-test/2269/
• ttcn3-remsim-test was also affected and recovered now: https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-remsim-test/1305/
• likewise, https://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_virtual/7512/ is back to normal