Bug #5954
closedttcn3-bts-test: TC_pcu_data_ind_lqual_cb is failing
100%
Description
This testcase was added by me back in 2019 and was known to pass:
commit a2c68e81f941ad7b8e4d8f422c898c237a8d0e77 Author: Vadim Yanitskiy <axilirator@gmail.com> Date: Wed Jul 3 13:07:20 2019 +0700 BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb
but has been reliably failing during the past 150 days with the following output:
"BTS_Tests.ttcn:5919 : Rx unexpected PCUIF_DATA.ind: { msg_type := PCU_IF_MSG_DATA_IND (2), bts_nr := 0, spare := '0000'O, u := { data_ind := { sapi := PCU_IF_SAPI_PDTCH (5), len := 0, data := ''O, fn := 780, arfcn := 871, trx_nr := 0, ts_nr := 7, block_nr := 0, rssi := -18, ber10k := 10000, ta_offs_qbits := 0, lqual_cb := -32738 } } }" BTS_Tests.ttcn:8983 BTS_Tests control part BTS_Tests.ttcn:5959 TC_pcu_data_ind_lqual_cb testcase
Related issues
Updated by fixeria about 1 year ago
- Related to Feature #1855: provide actual BER or C/I values from osmo-bts-trx into the PCU added
Updated by fixeria 12 months ago
- Status changed from New to In Progress
- % Done changed from 0 to 40
This testcase is failing for several reasons:
- the TC is sending a L1CTL BLOCK.req with dummy Fn=0, trxcon/l1sched drops this block:
TS7-PTCCH l1sched_lchan_prim_dequeue(): dropping Tx primitive (current Fn=844, prim Fn=0)
- the IUT does not enforce the minimum link quality threshold anymore and does pass all blocks:
commit a21545e3742dc93c566e63a3e940880e8dca97cd Author: Pau Espin Pedrol <pespin@sysmocom.de> Date: Tue Mar 7 17:58:10 2023 +0100 pcu_sock: Submit all DATA.ind regardless of link quality
I've submitted several fixes:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33106 BTS_Tests: cosmetic: add as_pcuif_msg() for convenience [NEW]
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33107 BTS_Tests.TC_pcu_data_ind_lqual_cb: log lqual values [NEW]
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33108 BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req [NEW]
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33109 BTS_Tests.TC_pcu_data_ind_lqual_cb: remove lqual threshold [NEW]
however the testcase is still failing. There are more problems to be fixed:
- we're running trxcon with
fn_advance=3
by default, so Uplink BLOCK requests are always late, - for some reason, TITAN v8.3.0 is having problems decoding negative lqual values in PCUIF DATA.ind.
Updated by fixeria 9 months ago
- Status changed from In Progress to Feedback
- % Done changed from 40 to 100
fixeria wrote in #note-2:
however the testcase is still failing. There are more problems to be fixed:
- we're running trxcon with
fn_advance=3
by default, so Uplink BLOCK requests are always late,
This is no longer the case:
commit 923e9b0b90622a7977c73ddd264d7cc48439098f Author: Vadim Yanitskiy <vyanitskiy@sysmocom.de> Date: Mon Jun 5 04:17:48 2023 +0700 trxcon: do not advance Uplink TDMA Fn by default commit 45c821aee08e5f91273b0e203a1a04cff60114c8 Author: Vadim Yanitskiy <vyanitskiy@sysmocom.de> Date: Sat Nov 26 08:07:25 2022 +0700 trxcon: get rid of the timer driven clock module
- for some reason, TITAN v8.3.0 is having problems decoding negative lqual values in PCUIF DATA.ind.
TITAN v9.0.0 exhibits the same behavior. This patch fixes the problem:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34247 PCUIF: fix coding of 'lqual_cb' field in PCUIF_data [NEW]