Project

General

Profile

Actions

Bug #4178

closed

libgtp: Fix use os gtp_retranstimeout() APIs in osmo-ggsn and osmo-sgsn

Added by pespin over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
libgtp
Target version:
-
Start date:
08/28/2019
Due date:
% Done:

100%

Spec Reference:

Description

Currently libgtp provides gtp_retranstimeout() and gtp_retrans() APIs to handle retransmission of tx packets and dropping of enqueued duplicate checks.

The idea is that gtp_retranstimeout() provides through an out param the first time when gtp_retrans() needs to be called to handle all events.
However, that means whenever a new packet is transmitted/enqueued using libgtp API, gtp_retranstimeout() must be called by the application to schedule the timer again, because retransmission from that new packet may come before other already-scheduled events.
We are currently not doing that.

I am actually preparing a patch to drop those APIs completely (leave them as no-ops actually) and handle everything correctly internally through osmocom timers. That part is mostly done, but I need to remember to update the internal timers every time gtp_req() is called.


Related issues

Related to OsmoGGSN (former OpenGGSN) - Bug #4165: osmo-ggsn: implement echo request against osmo-sgsnResolvedpespin08/21/2019

Actions
Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)