Bug #3717: SS/USSD: fix SS session inactivity timeout - OsmoHLR - Open Source Mobile Communications

Actions

Copy link

Bug #3717

open

SS/USSD: fix SS session inactivity timeout

Added by fixeria over 5 years ago. Updated over 5 years ago.

Status:

Stalled

Priority:

High

Assignee:

fixeria

Target version:

Start date:

11/30/2018

Due date:

% Done:

80%

Spec Reference:

Description

I just discovered that SS session inactivity timeout is never being rescheduled.

See ss_session_alloc() in 'src/hlr_ussd.c':

osmo_timer_setup(&ss->timeout, ss_session_timeout, ss);
/* NOTE: The timeout is currently global and not refreshed with subsequent messages
 * within the SS/USSD session.  So 30s after the initial SS message, the session will
 * timeout! */
osmo_timer_schedule(&ss->timeout, 30, 0);

The correct behaviour would be to reschedule the timer on any activity.
Also, makes sense to have a possibility to configure this timer from the VTY.

Hide closed

Checklist