Project

General

Profile

Actions
Copy link

Bug #5958

closed

Osmocom Debian packages don't run systemctl daemon-reload

Added by osmith about 1 year ago. Updated almost 1 year ago.

Status:
Resolved
Priority:
High
Assignee:
osmith
Target version:
-
Start date:
03/24/2023
Due date:
% Done:

100%

Spec Reference:

Description

We should build the debian packages with:

%:
    dh $@ --with systemd

So that the debhelper scripts properly run systemctl daemon-reload, restart services on upgrades etc.

See:
Actions
Copy link
 #1

Updated by laforge about 1 year ago

  • Priority changed from Normal to High
Actions
Copy link
 #2

Updated by osmith about 1 year ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 20

Instead of --with systemd, we should upgrade the debhelper compat levels of the packages, it is enabled by default for >= 10 (see here).

We support debian 10 and higher. Debian 10 has debhelper version 12.1.1, which supports compat levels up to v12.

So I'll adjust our packages to use level 12.

Actions
Copy link
 #3

Updated by osmith about 1 year ago

  • % Done changed from 20 to 90
Patches:
  • Set compat level 12 via Build-Depends: debhelper-compat (= 12) and remove the old debian/compat file (as suggested here, note that even though it says "= 12" it also works with higher versions of debhelper)
  • Set the maintainer everywhere to "Osmocom team <>". We already had this in some packages, make it consistent.

https://gerrit.osmocom.org/q/topic:dh-12

Actions
Copy link
 #4

Updated by osmith about 1 year ago

  • % Done changed from 90 to 60

I'll just let jenkins build all of them in CI verification and fix the ones that fail. Apparently not all just work after upgrading the level.

Actions
Copy link
 #5

Updated by osmith about 1 year ago

pespin pointed out in chat that we might not want to break compatibility with debian 9 yet, just in case somebody is still using it.

debian 9 has debhelper version 10.2.5 (listed here as o-o-stable), which supports compatibility level v10.

This still fixes the systemd problem, so I'll adjust the patches to use that.

Actions
Copy link
 #6

Updated by osmith about 1 year ago

  • % Done changed from 60 to 80
Actions
Copy link
 #7

Updated by osmith about 1 year ago

A nice side-effect is, that with v10 debhelper doesn't use -j1 anymore by default. It should speed up building all debian packages a bit.

Actions
Copy link
 #8

Updated by osmith about 1 year ago

  • % Done changed from 80 to 90

CI passes for all patches now, waiting for review.

https://gerrit.osmocom.org/q/topic:dh-12+status:open

Actions
Copy link
 #9

Updated by osmith about 1 year ago

As mentioned in code review: the update checklist is here https://manpages.debian.org/testing/debhelper/debhelper-compat-upgrade-checklist.7.en.html and I've read through it.

Actions
Copy link
 #10

Updated by osmith about 1 year ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100
Actions
Copy link
 #11

Updated by osmith almost 1 year ago

libusrp failed with 2/18 builds after bumping the compat version with the errors noted in #3970.

Patch to disable parallel building for it:
https://gerrit.osmocom.org/c/libusrp/+/32545

All other packages built fine on OBS.

Actions
Copy link

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)