Cellular Network Infrastructure » Radio Access Network » OsmoBSC

Some time ago I already noticed that the osmo-bsc conn clearing procedure is full of holes.
At the time I started the branch neels/clear to make the gscon FSM waterproof in its release/clear handling.
Then some other things became higher priority, and i lost track a bit.

But now I see that the branch in fact has the proper fix(es) for this leak.
So went back to it now and it didn't take too long to iron out the last bits of it.

Among other things, I add a safeguard timeout for waiting for an SCCP RLSD,
which of course will never arrive when there is no MSC
(the main reason for the leak -- the clear procedure never finishes).

In a second step, I add a tweak so that in case of no SCCP conn being present, we also skip the safeguard timeout
and dealloc the conn immediately, hence drop the use count on bsc_subscr, and fix the conn and subscr leaks.

In BSC_Tests, I verify that the talloc context shows zero bsc_subscr and gsm_subcsriber_connection entries.
Adding this to f_shutdown_helper(), so that most tests will now implicitly safeguard against subscr and conn leaks.

This also means that all tests than run after a leak-provoking test will light up red, from the single earlier leak.
That's because a leaked bsc_subscr stays around in the talloc report forever.
Especially for the "latest" tests, that will look like massive fallout, even though it just shows a long
existing bug.

Still running through the entire BSC_Tests.* to verify, will then post the patches.