Bug #3679
closed
bsc_vty.c iterates trx to regen sysinfo manually, skips bcch_change_mark bump
Added by neels over 5 years ago.
Updated almost 4 years ago.
Description
See gsm_bts_set_system_infos() in bsc_init.c, which increments bcch_change_mark.
Compare bts_resend_cmd in bsc_vty.c which does
llist_for_each_entry_reverse(trx, &bts->trx_list, list)
gsm_bts_trx_set_system_infos(trx);
and doesn't increment bcch_change_mark.
Does this need fixing?
- Status changed from Feedback to In Progress
- % Done changed from 0 to 70
related, I'm not sure about this at all, but I now also notice a possible similar problem in bootstrap_rsl() in osmo_bsc_main.c:
static void bootstrap_rsl(struct gsm_bts_trx *trx)
{
[...]
gsm_bts_trx_set_system_infos(trx);
static int inp_sig_cb(unsigned int subsys, unsigned int signal,
void *handler_data, void *signal_data)
{
[...]
switch (signal) {
case S_L_INP_TEI_UP:
[...]
if (isd->link_type == E1INP_SIGN_RSL)
bootstrap_rsl(trx);
So whenever a BTS reconnects and brings a TRX up, there is no bcch_change_mark increment,
because this only calls gsm_bts_TRX_set_system_infos() and not gsm_BTS_set_system_infos().
Is that fine?
- Status changed from In Progress to Resolved
- % Done changed from 70 to 100
Also available in: Atom
PDF
