Project

General

Profile

Actions

Bug #3584

closed

libosmovty/command.c: (!elem->attr & CMD_ATTR_DEPRECATED), missing parentheses?

Added by fixeria over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
libosmovty
Target version:
-
Start date:
09/24/2018
Due date:
% Done:

100%

Spec Reference:

Description

Just noticed while building with clang-4.0:

make[2]: Entering directory `/home/.../osmocom/libosmocore/src/vty'
  CC       buffer.lo
  CC       command.lo
  CC       utils.lo
  CC       vector.lo
  CC       vty.lo
command.c:682:8: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]
                        if (!elem->attr & CMD_ATTR_DEPRECATED)
                            ^           ~
command.c:682:8: note: add parentheses after the '!' to evaluate the bitwise operator first
                        if (!elem->attr & CMD_ATTR_DEPRECATED)

This warning appears a few times. I guess (not sure) the condition should look like this:

if (!elem->attr & CMD_ATTR_DEPRECATED) ...
Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)