Project

General

Profile

Feature #2517

use libosmocore counters for packet/byte counting (statistics)

Added by dexter 10 months ago. Updated 14 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
09/22/2017
Due date:
% Done:

100%

Estimated time:

Description

use any of the libosmocore counters, rather than having hand-coded counters. A rate counter would have the benefit that it would come with free CTRL interface access to the counters.

(see also the SGSN/PDP-Context per direction packet and byte counting)

History

#1 Updated by laforge 10 months ago

#2 Updated by dexter 4 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 20

I have replaced state.in_stream.err_ts_counter and state.out_stream.err_ts_counter with libosmocore counters. There are still a couple more counters I think.

#3 Updated by dexter 4 months ago

We have an approach for libosmocore counters: https://gerrit.osmocom.org/#/c/7396/ but we agreed not to merge it. We will go for rate counters instead that are much better alternative and also have better control interface support.

#4 Updated by dexter 4 months ago

  • % Done changed from 20 to 30

There is now an alternate patch that uses libosmocore rate counters:
https://gerrit.osmocom.org/7555 stats: use libosmocore rate counter for in/out_stream.err_ts_counter

#5 Updated by dexter 3 months ago

Unfortunately the patch got reverted.

https://gerrit.osmocom.org/7891
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/xUbuntu_17.04/i586

When looking at the OBS log I can see that there is some unexpected output. We need to check whats behind this and resubmit the patch when the error has been found.

#6 Updated by dexter 3 months ago

  • Status changed from In Progress to Feedback
  • Assignee changed from dexter to lynxis

lynxis: How can I retrieve the log from the build failure, I only added the link to the top build to the ticket. In order to pinpoint the problem, I need the logtext form the failure situation.

#7 Updated by lynxis 3 months ago

dexter: I've created a 32bit lxc container to test it.

#8 Updated by dexter 2 months ago

  • Assignee changed from lynxis to dexter

The build problem under OBS was most likely a problem an integer size problem on the 32-bit build. I managed to reproduce the faulure under an 32 bit debian VM and fixed it. Here is the new version of the patch:

https://gerrit.osmocom.org/8086 stats: use libosmocore rate counter for in/out_stream.err_ts_counter

#9 Updated by dexter 19 days ago

  • Status changed from Feedback to In Progress
  • % Done changed from 30 to 90

I have now replaced the counters that relate to packet/byte counting. See also:

https://gerrit.osmocom.org/#/c/osmo-mgw/+/9837 stats: replace packet statistic counters with libosmocore rate counters

#10 Updated by dexter 14 days ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

As far as I can see we have now joined all relevant counters inside a rate counter group. Whats left is struct mgcp_conn_rtp.osmux.stats. I would suggest to fix this when osmux support is re-introduced. Until now this would only increase the confusion about osmux.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)