use libosmocore counters for packet/byte counting (statistics)
use any of the libosmocore counters, rather than having hand-coded counters. A rate counter would have the benefit that it would come with free CTRL interface access to the counters.
(see also the SGSN/PDP-Context per direction packet and byte counting)
#5 Updated by dexter about 1 year ago
Unfortunately the patch got reverted.
When looking at the OBS log I can see that there is some unexpected output. We need to check whats behind this and resubmit the patch when the error has been found.
#6 Updated by dexter about 1 year ago
- Status changed from In Progress to Feedback
- Assignee changed from dexter to lynxis
lynxis: How can I retrieve the log from the build failure, I only added the link to the top build to the ticket. In order to pinpoint the problem, I need the logtext form the failure situation.
#8 Updated by dexter about 1 year ago
- Assignee changed from lynxis to dexter
The build problem under OBS was most likely a problem an integer size problem on the 32-bit build. I managed to reproduce the faulure under an 32 bit debian VM and fixed it. Here is the new version of the patch:
https://gerrit.osmocom.org/8086 stats: use libosmocore rate counter for in/out_stream.err_ts_counter
- Status changed from Feedback to In Progress
- % Done changed from 30 to 90
I have now replaced the counters that relate to packet/byte counting. See also:
https://gerrit.osmocom.org/#/c/osmo-mgw/+/9837 stats: replace packet statistic counters with libosmocore rate counters
- Status changed from In Progress to Resolved
- % Done changed from 90 to 100
As far as I can see we have now joined all relevant counters inside a rate counter group. Whats left is struct mgcp_conn_rtp.osmux.stats. I would suggest to fix this when osmux support is re-introduced. Until now this would only increase the confusion about osmux.