Bug #1876
closed
vty should complain about unknown pchan in config file
Added by neels over 7 years ago.
Updated over 5 years ago.
Description
If I misspell or freely invent PCHAN names in the osmo-nitb.cfg, osmo-nitb happily starts up
and all we get is a value error upon OML channel init.
The VTY should parse the pchan names and make sure only known channel names are used in the config file,
or reject startup with a parse error.
Example for a misspelled pchan:
[...]
timeslot 2
phys_chan_config TCH/F_TCH/H_PDasdfasCH
hopping enabled 0
timeslot 3
phys_chan_config TCH/F_TCH/H_asdfasdafdsPDCH
hopping enabled 0
[...]
- Project changed from OpenBSC to OsmoBSC
side note: it makes sense to abort the program startup, but not to abort a running osmo-bsc from the interactive telnet VTY.
It is possible to find out whether the command came from an interactive VTY or from initial config file:
if (vty->type == VTY_FILE)
OSMO_ASSERT(valid_string);
- Status changed from New to In Progress
- Status changed from In Progress to Resolved
Above patch has been merged.
Also available in: Atom
PDF
