Cellular Network Infrastructure » Core Network (CN) » OsmoHNBGW

I think this code is a good place to find a better name:

context_map_sccp.c:

static int tx_sccp_rlsd(struct osmo_fsm_inst *fi)
{
        struct hnbgw_context_map *map = fi->priv;

        if (!map->cnlink || !map->cnlink->hnbgw_sccp_user) {
                LOGPFSML(fi, LOGL_ERROR, "Failed to send SCCP RLSD: no CN link\n");
                return -1;      
        }                       

        return osmo_sccp_tx_disconn(map->cnlink->hnbgw_sccp_user->sccp_user, map->scu_conn_id, NULL, 0);
}    

IIUC these points exist:

• tx_sccp_rlsd() implies that a RLSD message will be sent on the wire, but the SCCP-SCOC FSM will do a number of different things that get it to disconnect. So instead of 'rlsd' it should say 'disconn'?

• The "tx" implies a message on the wire, while it is a dispatching of a primitive, more like an FSM event. Instead of "tx" it should say "dispatch"?

Interesting also is, osmo_sccp_tx_disconn() is from osmocom/sigtran/sccp_helpers.h. It has "disconn" in its name but also the "tx".

I'd like to get some feedback on what name would be satisfactory here, instead of tx_sccp_rlsd().
Maybe tx_sccp_disconn()? Or rather dispatch_sccp_disconn()? just sccp_disconn()?