Feature #4309
closed
MOSS stage 2 review item: mslookup mDNS: add IANA permitted TLD to the mslookup queries
Added by neels over 4 years ago.
Updated over 4 years ago.
Description
add '.osmocom.org' or '.mslookup.osmocom.org' or '.mdns.osmocom.org' to the URL string sent in mDNS queries.
We could add it all around end-to-end, or just on the wire in the DNS packets: add when sending and strip when receiving.
- Only on the DNS wire makes sense when considering that if we invent other methods for mslookup, it might be by GSUP or whatever, which doesn't compete with IANA naming.
- end-to-end makes sense when trying to be conform / similar across all query methods.
I think I slightly favor only on the DNS wire.
So that in osmo_mslookup_client all we see is still, as now, 'sip.voice.12345.msisdn', but in DNS packets sent and received we have 'sip.voice.12345.msisdn.mdns.osmocom.org'
- Status changed from New to In Progress
- % Done changed from 0 to 50
I think I slightly favor only on the DNS wire.
This makes more sense to me, since we don't have the domain suffix in the mslookup query struct, and it doesn't really belong there.
Pushed WIP state to osmith/dgsm.
So far I'm adding and removing the domain_suffix in mdns.c, and it's possible to set the suffix when initializing the mslookup mdns method (since Harald mentioned that it would be nice to have it configurable), and the related test is passing. A define for the default is set to "dgsm.osmocom.org". I've adjusted osmo-mslookup-client to add the flag there as well.
Missing is adjusting the OsmoHLR mslookup server and client code, and implementing the VTY option.
- Status changed from In Progress to Resolved
- % Done changed from 50 to 100
Missing is adjusting the OsmoHLR mslookup server and client code, and implementing the VTY option.
Done, patches updated.
As discussed with neels, I've also renamed "mdns" to "mdns bind" in the vty config, so it does not look weird when used in combination with the new "mdns domain-suffix" option.
Example config:
mslookup
mdns bind
mdns domain-suffix dgsm.sysmocom.de
server
server sip.voice at 127.0.0.1 5060
- Related to Bug #4350: explain mDNS domain-suffix in osmo-hlr manuals added
Also available in: Atom
PDF
