Project

General

Profile

Actions

Bug #6227

closed

gapk release tarballs missing from https://ftp.osmocom.org/releases/

Added by laforge 4 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
10/18/2023
Due date:
% Done:

100%

Spec Reference:

Actions #1

Updated by osmith 4 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 90
Actions #2

Updated by osmith 4 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100
Actions #3

Updated by fixeria 4 months ago

BTW, it would be good to tag a release for gapk.git.
The last release (v0.4) was quite a long time ago, back in 2017.
There have been quite a lot of activity since then...

Actions #4

Updated by osmith 4 months ago

fixeria wrote in #note-3:

BTW, it would be good to tag a release for gapk.git.
The last release (v0.4) was quite a long time ago, back in 2017.
There have been quite a lot of activity since then...

Looks like we don't have much of a release process for gapk. There is no debian packaging, so no debian/changelog to be updated. The previous tags also don't contain any information:
https://gitea.osmocom.org/osmocom/gapk/tags

So I suggest creating a new signed tag and pushing it:

$ git tag -s v0.5
$ git push origin v0.5

The release tarballs script should automatically pick it up and build the tarball when it runs (nightly).

fixeria: Do you want to create the tag and push it? Not sure if you want to make any changes to master beforehand.

Actions #5

Updated by laforge 4 months ago

added tnt as watcher here, as he's the original author of gapk.

Actions #6

Updated by fixeria 4 months ago

osmith wrote in #note-4:

So I suggest creating a new signed tag and pushing it: [...]

I can take care of that, just one thing.
I would tag v1.0 rather than v0.5 given the number of changes we had since v0.4.
Any objections?

Actions #7

Updated by fixeria 4 months ago

fixeria wrote in #note-6:

osmith wrote in #note-4:

So I suggest creating a new signed tag and pushing it: [...]

I can take care of that, just one thing.
I would tag v1.0 rather than v0.5 given the number of changes we had since v0.4.

For the record, I just pushed https://cgit.osmocom.org/gapk/tag/?h=v1.0.

Actions #8

Updated by fixeria 4 months ago

  • Status changed from Resolved to New

There is a problem with these release tarballs available at:

https://downloads.osmocom.org/releases/gapk/

unlike the other release tarballs (libosmocore, for instance), these contain no configure script:

$ tar -tvf gapk-v1.0.tar.bz2
-rw-rw-r-- root/root        22 2023-08-27 18:09 .checkpatch.conf
-rw-rw-r-- root/root       608 2023-08-27 18:09 .gitignore
-rw-rw-r-- root/root        46 2023-08-27 18:09 .gitreview
-rw-rw-r-- root/root       218 2023-08-27 18:09 Makefile.am
-rw-rw-r-- root/root       955 2023-08-27 18:09 README.md
-rw-rw-r-- root/root      3611 2023-08-27 18:09 configure.ac
drwxrwxr-x root/root         0 2023-08-27 18:09 contrib/
-rwxrwxr-x root/root       483 2023-08-27 18:09 contrib/benchmark.sh
-rw-rw-r-- root/root      4268 2023-08-27 18:09 contrib/gapk.spec.in
-rwxrwxr-x root/root       225 2023-08-27 18:09 contrib/gen_testdata.sh
-rwxrwxr-x root/root       984 2023-08-27 18:09 contrib/jenkins.sh
-rwxrwxr-x root/root      5440 2023-08-27 18:09 git-version-gen
-rw-rw-r-- root/root     35147 2023-08-27 18:09 gpl-3.0.txt
drwxrwxr-x root/root         0 2023-08-27 18:09 include/
-rw-rw-r-- root/root       339 2023-08-27 18:09 include/Makefile.am
drwxrwxr-x root/root         0 2023-08-27 18:09 include/gsmhr/
-rw-rw-r-- root/root        25 2023-08-27 18:09 include/gsmhr/Makefile.am
-rw-rw-r-- root/root      1092 2023-08-27 18:09 include/gsmhr/gsmhr.h
drwxrwxr-x root/root         0 2023-08-27 18:09 include/osmocom/
drwxrwxr-x root/root         0 2023-08-27 18:09 include/osmocom/gapk/
-rw-rw-r-- root/root      1522 2023-08-27 18:09 include/osmocom/gapk/bench.h
-rw-rw-r-- root/root      1372 2023-08-27 18:09 include/osmocom/gapk/benchmark.h
-rw-rw-r-- root/root      2621 2023-08-27 18:09 include/osmocom/gapk/codecs.h
-rw-rw-r-- root/root       785 2023-08-27 18:09 include/osmocom/gapk/common.h
-rw-rw-r-- root/root      2565 2023-08-27 18:09 include/osmocom/gapk/formats.h
-rw-rw-r-- root/root      4219 2023-08-27 18:09 include/osmocom/gapk/get_cycles.h
-rw-rw-r-- root/root       921 2023-08-27 18:09 include/osmocom/gapk/logging.h
-rw-rw-r-- root/root      3825 2023-08-27 18:09 include/osmocom/gapk/procqueue.h
-rw-rw-r-- root/root      2058 2023-08-27 18:09 include/osmocom/gapk/utils.h
drwxrwxr-x root/root         0 2023-08-27 18:09 libgsmhr/
-rw-rw-r-- root/root      1054 2023-08-27 18:09 libgsmhr/Makefile.am
-rwxrwxr-x root/root      1573 2023-08-27 18:09 libgsmhr/fetch_sources.py
-rw-rw-r-- root/root      3028 2023-08-27 18:09 libgsmhr/libgsmhr.c
drwxrwxr-x root/root         0 2023-08-27 18:09 libgsmhr/patches/
-rw-rw-r-- root/root     20629 2023-08-27 18:09 libgsmhr/patches/0001-Fix-round-function-name-conflict.patch
-rw-rw-r-- root/root      1055 2023-08-27 18:09 libgsmhr/patches/0002-Use-int-for-longword-so-they-are-32-bits-even-on-x64.patch
-rw-rw-r-- root/root       555 2023-08-27 18:09 libgsmhr/patches/0003-Remove-unused-variables.patch
-rw-rw-r-- root/root      6312 2023-08-27 18:09 libgsmhr/patches/0004-Make-sure-all-constants-are-marked-as-such.patch
-rw-rw-r-- root/root      1310 2023-08-27 18:09 libgsmhr/patches/0005-Remove-globals-initialization.patch
-rw-rw-r-- root/root      2890 2023-08-27 18:09 libgsmhr/patches/0006-Allow-inlining-of-most-of-the-math-function-for-bett.patch
-rw-rw-r-- root/root       267 2023-08-27 18:09 libosmogapk.pc.in
drwxrwxr-x root/root         0 2023-08-27 18:09 m4/
-rw-rw-r-- root/root         0 2023-08-27 18:09 m4/.gitkeep
drwxrwxr-x root/root         0 2023-08-27 18:09 src/
-rw-rw-r-- root/root      1828 2023-08-27 18:09 src/Makefile.am
-rw-rw-r-- root/root     20190 2023-08-27 18:09 src/app_osmo_gapk.c
-rw-rw-r-- root/root      2188 2023-08-27 18:09 src/benchmark.c
-rw-rw-r-- root/root      2689 2023-08-27 18:09 src/codec_amr.c
-rw-rw-r-- root/root      2746 2023-08-27 18:09 src/codec_efr.c
-rw-rw-r-- root/root      2640 2023-08-27 18:09 src/codec_fr.c
-rw-rw-r-- root/root      2191 2023-08-27 18:09 src/codec_hr.c
-rw-rw-r-- root/root       948 2023-08-27 18:09 src/codec_pcm.c
-rw-rw-r-- root/root      1444 2023-08-27 18:09 src/codecs.c
-rw-rw-r-- root/root      1082 2023-08-27 18:09 src/common.c
-rw-rw-r-- root/root      1882 2023-08-27 18:09 src/ecu_fr.c
-rw-rw-r-- root/root      2173 2023-08-27 18:09 src/fmt_amr.c
-rw-rw-r-- root/root      1535 2023-08-27 18:09 src/fmt_amr_opencore.c
-rw-rw-r-- root/root      1741 2023-08-27 18:09 src/fmt_gsm.c
-rw-rw-r-- root/root      4453 2023-08-27 18:09 src/fmt_hr_ref.c
-rw-rw-r-- root/root      4032 2023-08-27 18:09 src/fmt_racal.c
-rw-rw-r-- root/root      1739 2023-08-27 18:09 src/fmt_rawpcm.c
-rw-rw-r-- root/root      2090 2023-08-27 18:09 src/fmt_rtp_amr.c
-rw-rw-r-- root/root      2810 2023-08-27 18:09 src/fmt_rtp_efr.c
-rw-rw-r-- root/root      1954 2023-08-27 18:09 src/fmt_rtp_hr_etsi.c
-rw-rw-r-- root/root      2283 2023-08-27 18:09 src/fmt_rtp_hr_ietf.c
-rw-rw-r-- root/root      5351 2023-08-27 18:09 src/fmt_ti.c
-rw-rw-r-- root/root      2871 2023-08-27 18:09 src/formats.c
-rw-rw-r-- root/root        52 2023-08-27 18:09 src/libosmogapk.map
-rw-rw-r-- root/root      5500 2023-08-27 18:09 src/pq_alsa.c
-rw-rw-r-- root/root      2608 2023-08-27 18:09 src/pq_codec.c
-rw-rw-r-- root/root      2469 2023-08-27 18:09 src/pq_ecu.c
-rw-rw-r-- root/root      3531 2023-08-27 18:09 src/pq_file.c
-rw-rw-r-- root/root      2448 2023-08-27 18:09 src/pq_format.c
-rw-rw-r-- root/root      7177 2023-08-27 18:09 src/pq_rtp.c
-rw-rw-r-- root/root      6178 2023-08-27 18:09 src/procqueue.c
drwxrwxr-x root/root         0 2023-08-27 18:09 tests/
-rw-rw-r-- root/root      2540 2023-08-27 18:09 tests/Makefile.am
-rw-rw-r-- root/root       118 2023-08-27 18:09 tests/atlocal.in
-rw-rw-r-- root/root       355 2023-08-27 18:09 tests/common.sh
drwxrwxr-x root/root         0 2023-08-27 18:09 tests/ecu/
-rw-rw-r-- root/root      3985 2023-08-27 18:09 tests/ecu/ecu_fr_test.c
-rw-rw-r-- root/root     31757 2023-08-27 18:09 tests/ecu/ecu_fr_test.ok
drwxrwxr-x root/root         0 2023-08-27 18:09 tests/io/
-rw-rw-r-- root/root        32 2023-08-27 18:09 tests/io/io_sample.txt
-rw-rw-r-- root/root      3763 2023-08-27 18:09 tests/io/pq_file_test.c
-rw-rw-r-- root/root       386 2023-08-27 18:09 tests/io/pq_file_test.ok
-rw-rw-r-- root/root      8537 2023-08-27 18:09 tests/io/pq_rtp_test.c
-rw-rw-r-- root/root       218 2023-08-27 18:09 tests/io/pq_rtp_test.ok
-rwxrwxr-x root/root       284 2023-08-27 18:09 tests/play_all_formats.sh
drwxrwxr-x root/root         0 2023-08-27 18:09 tests/procqueue/
-rw-rw-r-- root/root      9225 2023-08-27 18:09 tests/procqueue/pq_test.c
-rw-rw-r-- root/root      1961 2023-08-27 18:09 tests/procqueue/pq_test.ok
drwxrwxr-x root/root         0 2023-08-27 18:09 tests/ref-files/
-rw-rw-r-- root/root     80000 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16
-rw-rw-r-- root/root      8006 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.amr-efr
-rw-rw-r-- root/root     80000 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.amr-efr.s16
-rw-rw-r-- root/root      8250 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.gsm
-rw-rw-r-- root/root     80000 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.gsm.s16
-rw-rw-r-- root/root      7750 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.racal-efr
-rw-rw-r-- root/root     80000 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.racal-efr.s16
-rw-rw-r-- root/root      8250 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.racal-fr
-rw-rw-r-- root/root     80000 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.racal-fr.s16
-rw-rw-r-- root/root      3500 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.racal-hr
-rw-rw-r-- root/root     80000 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.racal-hr.s16
-rw-rw-r-- root/root      7750 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.rtp-efr
-rw-rw-r-- root/root     80000 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.rtp-efr.s16
-rw-rw-r-- root/root      3500 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.rtp-hr-etsi
-rw-rw-r-- root/root     80000 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.rtp-hr-etsi.s16
-rw-rw-r-- root/root      3750 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.rtp-hr-ietf
-rw-rw-r-- root/root     80000 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.rtp-hr-ietf.s16
-rw-rw-r-- root/root      8250 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.ti-efr
-rw-rw-r-- root/root     80000 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.ti-efr.s16
-rw-rw-r-- root/root      8250 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.ti-fr
-rw-rw-r-- root/root     80000 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.ti-fr.s16
-rw-rw-r-- root/root      8250 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.ti-hr
-rw-rw-r-- root/root     80000 2023-08-27 18:09 tests/ref-files/hhgttg_part1_5.s16.ti-hr.s16
-rwxrwxr-x root/root      1204 2023-08-27 18:09 tests/test_all_formats.sh
-rw-rw-r-- root/root      8323 2023-08-27 18:09 tests/testsuite.at
-rwxrwxr-x root/root       472 2023-08-27 18:09 tests/update_ref_files.sh
Actions #9

Updated by osmith 4 months ago

fixeria wrote in #note-8:

There is a problem with these release tarballs available at:

https://downloads.osmocom.org/releases/gapk/

unlike the other release tarballs (libosmocore, for instance), these contain no configure script:

[...]

This is on purpose, see the comment here:
Actions #10

Updated by osmith 4 months ago

  • Status changed from New to Feedback
  • Assignee changed from osmith to fixeria
Actions #11

Updated by osmith 4 months ago

As discussed in IRC, currently fetch_sources.py runs when running "make dist-bzip2":

$ autoreconf -fi
$ ./configure
$ make dist-bzip2
Actions #12

Updated by osmith 4 months ago

Maybe we can fix the logic and tag a v1.1 release with it, that contains the ./configure script.

EDIT: we could also apply the fix to previous releases and regenerate them, if it is important. IMHO it's not a big problem to ask users to run autoreconf locally.

Actions #13

Updated by fixeria 4 months ago

I've submitted a patch excluding the downloaded source files from the release tarballs, plus some minor improvements:

https://gerrit.osmocom.org/c/gapk/+/34890 libgsmhr: fix unneeded dependency for libgsmhr.c [NEW]
https://gerrit.osmocom.org/c/gapk/+/34891 dist: include .[tarball-]version and git-version-gen files [NEW]
https://gerrit.osmocom.org/c/gapk/+/34892 dist: exclude libgsmhr files downloaded by fetch_sources.py [NEW]

Once these are merged, we can tag v1.1 and patch scripts/tarballs/prefer-configure.sh to return 0 for v1.1 and greater.

Actions #14

Updated by osmith 4 months ago

  • Status changed from Feedback to In Progress
  • Assignee changed from fixeria to osmith
  • % Done changed from 100 to 90

fixeria wrote in #note-13:

patch scripts/tarballs/prefer-configure.sh to return 0 for v1.1 and greater.

https://gerrit.osmocom.org/c/osmo-ci/+/34901

Actions #15

Updated by osmith 4 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

v1.1 release tarball was uploaded:
https://downloads.osmocom.org/releases/gapk/

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)