Project

General

Profile

Actions

Bug #6087

closed

Wrong message type for UPLINK SEIZED COMMAND in BSSAP_Types.ttcn

Added by jolly 8 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
-
Start date:
07/09/2023
Due date:
% Done:

100%

Spec Reference:

Description

The depositroy "https://gitea.osmocom.org/ttcn3/titan.ProtocolModules.BSSMAP" includes a file "src/branch/master/src/BSSAP_Types.ttcn" that defines the messages between MSC and BSS. The UPLINK SEIZED COMMAND, as defines in "type record PDU_BSSMAP_UplinkSeizedCommand" has wrong message type. It is '4E'O, but it must be '4D'O. I verified it against the TS 48.008. 4E'O is used for CHANGE CIRCUIT message.


Files

UplinkSeizedCommand.patch UplinkSeizedCommand.patch 1.12 KB Patch jolly, 07/10/2023 12:15 PM
Actions #2

Updated by laforge 8 months ago

  • Status changed from New to Feedback
  • Assignee set to laforge

the proper process for this is to submit the fix upstream. our own respository only exists to bridge the gap until upstream has merged it.

So please create an eclipse.org user account, confirm the CLA, create a fork of https://gitlab.eclipse.org/eclipse/titan/titan.ProtocolModules.BSSMAP_v11.2.0 on their gitlab instance and submit a pull request.

Actions #3

Updated by laforge 8 months ago

  • Status changed from Feedback to New
  • Assignee changed from laforge to jolly

for the osmocom.org repository (as interim fix until upstream fixes it), you can also log into gitea.osmocom.org, create a fork and submit your patch as PR.

Actions #4

Updated by laforge 8 months ago

laforge wrote in #note-3:

for the osmocom.org repository (as interim fix until upstream fixes it), you can also log into gitea.osmocom.org, create a fork and submit your patch as PR.

actually this is a mirror of a gerrit repo, so feel free to submit the patch against https://gerrit.osmocom.org/q/project:titan.ProtocolModules.BSSMAP

Actions #5

Updated by laforge 8 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 30
Actions #6

Updated by laforge 5 months ago

upstream patch was merged 2 months ago. Please update the issue status here, thanks.

Actions #7

Updated by laforge 5 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 30 to 100
Actions #8

Updated by jolly 4 months ago

  • Status changed from Resolved to Closed

The fix is already merged at eclipse.org. Our TTCN3 tests depend on that fix already.

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)