Bug #6034
closedpylint is not happy about cmd2 backwards compatibility
100%
Description
With the current pylint version we use, it is not possible to disable linting rules for whole blocks. This is confusing, as the documentation states it is possible.
https://gerrit.osmocom.org/c/pysim/+/32532/comments/11a5db4c_23e9ac80
Updated by fixeria 12 months ago
I submitted https://gerrit.osmocom.org/c/pysim/+/32729 to see which version we're actually running:
pylint==2.17.3
It was released 3 weeks ago, so it's quite recent already...
Updated by fixeria 12 months ago
- Assignee changed from osmith to fixeria
This is what I am getting when running pylint on dexter 's patchset:
$ python3 -m pylint -j0 --errors-only --disable E1102 --disable E0401 --enable W0301 pySim *.py ************* Module pySim-shell pySim-shell.py:30:4: E0611: No name 'fg' in module 'cmd2' (no-name-in-module) pySim-shell.py:30:4: E0611: No name 'bg' in module 'cmd2' (no-name-in-module) pySim-shell.py:154:8: E1123: Unexpected keyword argument 'use_ipython' in method call (unexpected-keyword-arg) pySim-shell.py:171:30: E1120: No value for argument 'settable_object' in constructor call (no-value-for-parameter) pySim-shell.py:173:30: E1120: No value for argument 'settable_object' in constructor call (no-value-for-parameter) pySim-shell.py:175:30: E1120: No value for argument 'settable_object' in constructor call (no-value-for-parameter) pySim-shell.py:176:30: E1120: No value for argument 'settable_object' in constructor call (no-value-for-parameter)
pySim-shell.py
seems to work with cmd2 v2.4.3 on my system, but pylint is not smart enough to skip checking conditional blocks for older cmd2 versions.
Updated by osmith 12 months ago
- Assignee set to osmith
- % Done changed from 0 to 90
As master-pysim has been failing for a few days, I looked into it. This fixes it:
https://gerrit.osmocom.org/c/pysim/+/32924/1
fixeria wrote in #note-2:
I submitted https://gerrit.osmocom.org/c/pysim/+/32729 to see which version we're actually running:
[...]
It was released 3 weeks ago, so it's quite recent already...
I've rebased your patch, it is pylint==2.17.4
now.
Updated by osmith 12 months ago
- Status changed from New to Resolved
- % Done changed from 90 to 100
Applied in changeset pysim|e47ea5f2e574491e69d9eb8ab9ee6fe13c7d78d5.