Bug #5956: ttcn3-bts-test: TC_rsl_rf_resource_ind is failing - OsmoBTS - Open Source Mobile Communications

Actions

Copy link

Bug #5956

closed

ttcn3-bts-test: TC_rsl_rf_resource_ind is failing

Added by fixeria 9 months ago. Updated about 2 months ago.

Status:

Resolved

Priority:

Normal

Assignee:

fixeria

Category:

osmo-bts-trx

Target version:

Start date:

03/21/2023

Due date:

% Done:

100%

Spec Reference:

Description

I added this testcase back in 2021 and it was passing for some time:

commit 98c4a1a3b9042c770657b3bbeff1eca675dce556
Author: Vadim Yanitskiy <vyanitskiy@sysmocom.de>
Date:   Fri Jun 4 18:46:06 2021 +0200

    BTS: add a test case for RF RESource INDication

    Change-Id: I78b6d8beffa5228a28231b75728e7aebdd3cb23c

until we added interference reporting for dynamic timeslots, which are not taken into account:

/* g_AllChannels contains all logical channels */
for (var integer i := 0; i < lengthof(g_AllChannels); i := i + 1) {
        var RslChannelNr chan_nr := g_AllChannels[i];

        /* FIXME: osmo-bts does not report for Osmocom style dynamic timeslots */
        if (mp_trx_pars[0].ts[chan_nr.tn].config == GSM_PCHAN_TCHH_TCHF_PDCH)
                { continue; }

        info := info & { valueof(ts_RSL_ResourceInfoItem(chan_nr, mp_interf_band)) };
}

~~The planet~~ osmo-bts is fine, the TC itself needs to be fixed.

Actions

Copy link

Updated by fixeria about 2 months ago

Status changed from New to In Progress

Actions

Copy link

Updated by fixeria about 2 months ago

I implemented handling of PDCH and dynamic timeslots in the testcase:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34672 BTS_Tests: separate generating g_AllChannels[] into a function [NEW]
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34673 BTS_Tests: fix TC_rsl_rf_resource_ind: handle dynTS and PDCH [NEW]

so it's expected to pass now, but somehow the interference band does not match now. Will keep investigating.

Actions

Copy link

Updated by fixeria about 2 months ago

Status changed from In Progress to Feedback
% Done changed from 0 to 100

fixeria wrote in #note-2:

so it's expected to pass now, but somehow the interference band does not match now. Will keep investigating.

I found the reason:

commit dd718d0ec67b77e35150ea3153f78ba964ba2c02 (HEAD -> fixeria/fixes)
Author: Vadim Yanitskiy
Date:   Fri Oct 6 22:58:07 2023 +0700

    BTS_Tests: fix TC_rsl_rf_resource_ind: update mp_interf_band

    At some point (see related commit) we changed the ordering of default
    interference boundaries from descending to ascending in osmo-bsc.
    However the testsuite was not updated.  Fix this.

    Change-Id: I4f0d0814c343c626f6f7e5bafb7ac46cd7f362f6
    Related: osmo-bsc.git Ie9bf4bf0c89418685b8ea5096332d22cfba7c521
    Related: SYS#5313, OS#5956

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34678 BTS_Tests: fix TC_rsl_rf_resource_ind: update mp_interf_band [NEW]

With this patch applied I finally got the testcase to pass again.

Actions

Copy link