Project

General

Profile

Actions

Bug #5845

closed

makefile mystery due to generated file

Added by Hoernchen over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
12/23/2022
Due date:
% Done:

0%

Spec Reference:

Description

A makefile expert should take a loook at my attempt to generate a file that leads to somewhat misleading build errors that are ignored, but are still annoying when attempting to find other buld issues:

ar: `u' modifier ignored since `D' is the default (see `U')
make[4]: Leaving directory '/build/Transceiver52M/device/common'
Making all in ipc
make[4]: Entering directory '/build/Transceiver52M/device/ipc'
echo "#include \"../uhd/UHDDevice.cpp\"" >uhddev_ipc.cpp
L/build/deps/install/stow/libosmocore/lib -losmocore -ltalloc \

/bin/bash: L/build/deps/install/stow/libosmocore/lib: No such file or directory
make[4]: [Makefile:969: uhddev_ipc.cpp] Error 127 (ignored)
make  all-am
make[5]: Entering directory '/build/Transceiver52M/device/ipc'
  CC       ipc_driver_test-ipc-driver-test.o

Caused by https://gitea.osmocom.org/cellular-infrastructure/osmo-trx/src/branch/master/Transceiver52M/device/ipc/Makefile.am#L22

#work around distclean issue on older autotools vers:
#a direct build of ../uhd/UHDDevice.cpp tries to clean
#../uhd/.dep/UHDDevice.Plo twice and fails
uhddev_ipc.cpp:
    echo "#include \"../uhd/UHDDevice.cpp\"" >$@
CLEANFILES= uhddev_ipc.cpp
BUILT_SOURCES = uhddev_ipc.cpp
Actions #1

Updated by Hoernchen over 1 year ago

  • Subject changed from myakefile mystery due to generated file to makefile mystery due to generated file
Actions #2

Updated by osmith over 1 year ago

  • Status changed from New to Feedback
  • Assignee changed from osmith to Hoernchen

git blame points at this >2 year old patch https://gitea.osmocom.org/cellular-infrastructure/osmo-trx/commit/1e17c4fb0a77dcee49a7cd566dca7e8f48f6d8e7.

issue on older autotools vers

which version? if it works fine on more modern autotools (i.e. what's in debian 10 at least), maybe just remove the workaround?

Actions #3

Updated by fixeria over 1 year ago

osmith wrote in #note-2:

which version? if it works fine on more modern autotools (i.e. what's in debian 10 at least), maybe just remove the workaround?

Same here, builds without errors/warnings on Arch:

  • automake v1.16.5,
  • autocinf v2.71,
  • make v4.3.
Actions #4

Updated by Hoernchen over 1 year ago

I'll just give removing it a try, if it passes the jenkins build it is good to go, I guess..

Actions #5

Updated by Hoernchen over 1 year ago

  • Status changed from Feedback to Closed

Appears to work, the patch was introduced before we dropped some of the really old distros, so removing it was the fix.

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)