Project

General

Profile

Actions

Bug #5668

closed

Jenkins build verification is broken: pylint crashes

Added by fixeria over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
08/30/2022
Due date:
% Done:

100%

Spec Reference:

Description

None of the patches I submitted today passed Jenkins build verification:

+ pip install pylint

Requirement already satisfied: pylint in ./venv/lib/python3.7/site-packages (2.15.0)
Requirement already satisfied: isort<6,>=4.2.5 in ./venv/lib/python3.7/site-packages (from pylint) (5.10.1)
Requirement already satisfied: platformdirs>=2.2.0 in ./venv/lib/python3.7/site-packages (from pylint) (2.5.2)
Requirement already satisfied: dill>=0.2 in ./venv/lib/python3.7/site-packages (from pylint) (0.3.5.1)
Requirement already satisfied: tomli>=1.1.0 in ./venv/lib/python3.7/site-packages (from pylint) (2.0.1)
Requirement already satisfied: mccabe<0.8,>=0.6 in ./venv/lib/python3.7/site-packages (from pylint) (0.7.0)
Requirement already satisfied: tomlkit>=0.10.1 in ./venv/lib/python3.7/site-packages (from pylint) (0.11.4)
Requirement already satisfied: astroid<=2.14.0-dev0,>=2.12.4 in ./venv/lib/python3.7/site-packages (from pylint) (2.12.5)
Requirement already satisfied: typing-extensions>=3.10.0 in ./venv/lib/python3.7/site-packages (from pylint) (4.3.0)

Requirement already satisfied: typed-ast<2.0,>=1.4.0 in ./venv/lib/python3.7/site-packages (from astroid<=2.14.0-dev0,>=2.12.4->pylint) (1.5.4)
Requirement already satisfied: wrapt<2,>=1.11 in ./venv/lib/python3.7/site-packages (from astroid<=2.14.0-dev0,>=2.12.4->pylint) (1.14.1)
Requirement already satisfied: lazy-object-proxy>=1.4.0 in ./venv/lib/python3.7/site-packages (from astroid<=2.14.0-dev0,>=2.12.4->pylint) (1.7.1)

+ python -m pylint --errors-only --disable E1102 --disable E0401 --enable W0301 pySim pySim-prog.py pySim-read.py pySim-shell.py pySim-trace.py setup.py

Traceback (most recent call last):
  File "/home/jenkins/workspace/gerrit-pysim/a1/default/a2/default/a3/default/a4/default/label/simtester/venv/lib/python3.7/site-packages/astroid/inference_tip.py", line 38, in _inference_tip_cached
    result = _cache[func, node]
KeyError: (<function infer_named_tuple at 0x7f3b54e39268>, <Call l.195 at 0x7f3b4f5ab5f8>)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/jenkins/workspace/gerrit-pysim/a1/default/a2/default/a3/default/a4/default/label/simtester/venv/lib/python3.7/site-packages/astroid/brain/brain_namedtuple_enum.py", line 88, in infer_func_form
    attributes: list[str] = names.value.replace(",", " ").split()
  File "/home/jenkins/workspace/gerrit-pysim/a1/default/a2/default/a3/default/a4/default/label/simtester/venv/lib/python3.7/site-packages/astroid/bases.py", line 134, in __getattr__
    return getattr(self._proxied, name)
AttributeError: 'ClassDef' object has no attribute 'value'

During handling of the above exception, another exception occurred:

...

Looks like pylint is broken?


Related issues

Blocks pySim - Bug #5666: ModuleNotFoundError: No module named 'construct.lib.containers'Resolvedfixeria08/29/2022

Actions
Actions #2

Updated by fixeria over 1 year ago

https://jenkins.osmocom.org/jenkins/view/master/job/master-pysim/ is not affected because somehow it's using older pylint v2.14.5:

Requirement already satisfied: pylint in ./venv/lib/python3.7/site-packages (2.14.5)

Most likely, because we do not clean the workspace.

Actions #3

Updated by fixeria over 1 year ago

  • Blocks Bug #5666: ModuleNotFoundError: No module named 'construct.lib.containers' added
Actions #4

Updated by fixeria over 1 year ago

  • Status changed from New to Stalled

As a temporary workaround, I submitted a patch pinning v2.14.5, which is known to work:

https://gerrit.osmocom.org/c/pysim/+/29239 contrib/jenkins.sh: pylint v2.15 is unstable, pin v2.14.5 [NEW]

We can revert this patch once the upstream fixes the regression.

Actions #5

Updated by fixeria over 1 year ago

  • Status changed from Stalled to Feedback
  • % Done changed from 0 to 100

fixeria wrote in #note-4:

As a temporary workaround, I submitted a patch pinning v2.14.5, which is known to work:

https://gerrit.osmocom.org/c/pysim/+/29239 contrib/jenkins.sh: pylint v2.15 is unstable, pin v2.14.5 [NEW]

We can revert this patch once the upstream fixes the regression.

The workaround has been merged. Meanwhile, the upstream fixed the regression:

https://github.com/PyCQA/astroid/pull/1763
https://github.com/PyCQA/astroid/releases/tag/v2.12.6

which was not in pylint itself, but in its dependency.

Here is a revert:

https://gerrit.osmocom.org/c/pysim/+/29276 Revert "contrib/jenkins.sh: pylint v2.15 is unstable, pin v2.14.5" [NEW]

Actions #6

Updated by fixeria over 1 year ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)