https://projects.osmocom.org/https://projects.osmocom.org/favicon.ico?16647414092022-07-22T06:41:00ZOpen Source Mobile CommunicationsOsmoMSC - Bug #5568: SMPP socket doesn't use TCP_NODELAYhttps://projects.osmocom.org/issues/5568?journal_id=244332022-07-22T06:41:00Zlaforge
<ul><li><strong>Assignee</strong> set to <i>msuraev</i></li></ul> OsmoMSC - Bug #5568: SMPP socket doesn't use TCP_NODELAYhttps://projects.osmocom.org/issues/5568?journal_id=245102022-07-27T14:23:44Zmsuraev
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul><p>Indeed, libosmo-netif is better option - especially given that it's already used for SGs interface.</p> OsmoMSC - Bug #5568: SMPP socket doesn't use TCP_NODELAYhttps://projects.osmocom.org/issues/5568?journal_id=245252022-07-29T14:31:07Zmsuraev
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>50</i></li></ul><p>Draft is available in <a class="external" href="https://gerrit.osmocom.org/q/topic:SMPP">https://gerrit.osmocom.org/q/topic:SMPP</a> it passes python SMPP tests locally but those are rather rudimentry. If you have an idea for better testsuite - I'd be happy to give it a shot.</p> OsmoMSC - Bug #5568: SMPP socket doesn't use TCP_NODELAYhttps://projects.osmocom.org/issues/5568?journal_id=245262022-07-29T14:41:04Zfixeria
<ul></ul><p>Hi Max,</p>
<p>msuraev wrote in <a href="#note-3">#note-3</a>:</p>
<blockquote>
<p>Draft is available in <a class="external" href="https://gerrit.osmocom.org/q/topic:SMPP">https://gerrit.osmocom.org/q/topic:SMPP</a> it passes python SMPP tests locally but those are rather rudimentry. If you have an idea for better testsuite - I'd be happy to give it a shot.</p>
</blockquote>
<p>we have rather complete SMPP testing coverage in ttcn3-msc-test, so I recommend running it.</p> OsmoMSC - Bug #5568: SMPP socket doesn't use TCP_NODELAYhttps://projects.osmocom.org/issues/5568?journal_id=245942022-08-09T11:23:43Zlaforge
<ul></ul><p>I'm actually quite concerned that this has turned out such a comprehensive (and supposedly time-consuming) set of patches.</p>
<p>Adding a TCP_NODELAY to SMPP sockets was the problem. But now we have major refactoring of not only the entire SMPP codebase in osmo-msc.git (with large potentail of fall-out, if not only that all of the branches/patches in the pipeline need to be manually rebased), but also even down into libosmocore now.</p>
<p>I don't know all of the details of the related rationale, but to me, this ticket was about setting a simple socket option, please explain why this requires such extensive refactoring and changes across projects.</p> OsmoMSC - Bug #5568: SMPP socket doesn't use TCP_NODELAYhttps://projects.osmocom.org/issues/5568?journal_id=245952022-08-09T16:52:43Zmsuraev
<ul></ul><p>laforge wrote in <a href="#note-5">#note-5</a>:</p>
<blockquote>
<p>Adding a TCP_NODELAY to SMPP sockets was the problem. But now we have major refactoring of not only the entire SMPP codebase in osmo-msc.git</p>
</blockquote>
<p>While looking at SMPP code in OsmoMSC I've noticed that there're 2 partially overlapping implementations (MSC itself and smpp mirror) with handful of TODO comments about merging them. Also some of the fixes were applied to one but not the other. Hence it felt better to merge them first and than work on converting shared codebase to libosmo-netif.</p>
<blockquote>
<p>but also even down into libosmocore now.</p>
</blockquote>
<p>There should be no related patches in libosmocore. Have I misattributed some submission? Apologies if so. Could you please point to the corresponding gerrit link?</p>
<p><a class="external" href="https://gerrit.osmocom.org/q/topic:SMPP">https://gerrit.osmocom.org/q/topic:SMPP</a> - those should be the only related patches (half are merged already). I've tried to split it into smaller chunks to make review easier.</p>
<p>Shall I proceed with the current series or abandon it and send simple TCP_NODELAY socket option patch without converting to libosmo-netif?</p> OsmoMSC - Bug #5568: SMPP socket doesn't use TCP_NODELAYhttps://projects.osmocom.org/issues/5568?journal_id=250332022-10-08T16:23:13Zmsuraev
<ul><li><strong>% Done</strong> changed from <i>50</i> to <i>80</i></li></ul> OsmoMSC - Bug #5568: SMPP socket doesn't use TCP_NODELAYhttps://projects.osmocom.org/issues/5568?journal_id=253612022-11-11T14:56:11Zmsuraev
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Stalled</i></li></ul><p>Implemented in <a class="external" href="https://gerrit.osmocom.org/c/osmo-msc/+/28849">https://gerrit.osmocom.org/c/osmo-msc/+/28849</a> - waiting for review.</p> OsmoMSC - Bug #5568: SMPP socket doesn't use TCP_NODELAYhttps://projects.osmocom.org/issues/5568?journal_id=283722023-10-31T09:36:54Zlaforge
<ul><li><strong>Assignee</strong> changed from <i>msuraev</i> to <i>osmith</i></li></ul><p>I'm not sure it was wise to conflate the setting of a simple TCP_NODELAY socket option with migrating an entire third-party library over to libosmo-netif.</p>
<p>Maybe a very simple patch to add the nodelay option would be quick to merge.</p>