Project

General

Profile

Actions

Bug #5399

closed

disable / adjust linter for osmo-e1d / osmo-e1-firmware

Added by laforge about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Low
Assignee:
Target version:
-
Start date:
01/10/2022
Due date:
% Done:

100%

Spec Reference:

Description

tnt will remain to use his slightly not-really-osmocom coding style (who are we to tell him what he does in projects that he created in his spare time!), as expressed in https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26841

As osmith is on holidays now, I will disable the related linter jobs for the time being.

In general it might be an idea to have linter config in the project git repo, so individual projects can decide which exact options they wish to enable or disable.

Actions #2

Updated by osmith about 1 year ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 80

https://gerrit.osmocom.org/c/osmo-ci/+/26858

(Doesn't disable it for osmo-e1-hardware, only osmo-e1d and osmo-e1-recorder.)

In general it might be an idea to have linter config in the project git repo, so individual projects can decide which exact options they wish to enable or disable.

This is possible, added documentation here:
https://osmocom.org/projects/cellular-infrastructure/wiki/Linting#Project-specific-configuration

tnt, laforge: how about https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26927?

If this looks good, I can add such patches for osmo-e1d and osmo-e1-recorder as well and enable the linter again for those repositories.

Actions #4

Updated by osmith about 1 year ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100
Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)