Project

General

Profile

Bug #5173

Makefile.am uses HAVE_PCAP, HAVE_SQLITE3 to conditionally build some binaries

Added by osmith 14 days ago. Updated 14 days ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
06/07/2021
Due date:
% Done:

0%

Spec Reference:

Description

In https://gerrit.osmocom.org/c/osmo-bsc/+/24421, the jenkins verification passed, but the package fails to build in OBS:

meas_vis.c:196:16: error: 'struct gsm_meas_rep' has no member named 'bs_power'; did you mean 'bs_power_db'?

This is because Makefile.am builds meas_vis only if LIBCDK is installed, and apparently we don't have it installed on jenkins:

if HAVE_LIBCDK
bin_PROGRAMS += \
    meas_vis \
    $(NULL)
endif

To avoid this in the future, the "if HAVE_"s in Makefile.am need to be replaced with explicitly selecting/unselecting additional programs with ./configure flags. The default should not depend on what libraries are installed. (There was a mail thread or issue about this already, but I can't find it right now.)

Associated revisions

Revision b96f708f (diff)
Added by osmith 14 days ago

src/utils/meas_vis.c: fix bs_power -> bs_power_db

Fix build error:
meas_vis.c:196:16: error: 'struct gsm_meas_rep' has no member named 'bs_power'; did you mean 'bs_power_db'?

Output the value in the same format as before the change that introduced
this regression (dB / 2).

We didn't catch this regression with jenkins because meas_vis is only
built if libcdk is installed.

Related: OS#5173
Fixes: d9b7aedb ("change bs_power to bs_power_db")
Change-Id: I9ba9b491ccbde9aa14cfb14ecc551acb2bfd7674

History

#1 Updated by osmith 14 days ago

Related patches to fix the osmo-bsc problem (not removing "if HAVE" logic yet):

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)