https://projects.osmocom.org/https://projects.osmocom.org/favicon.ico?16647414092021-01-25T00:10:48ZOpen Source Mobile CommunicationsOsmoPCU - Bug #4973: NULL m_dl_egprs_ctrs passed to rate_ctr_add()https://projects.osmocom.org/issues/4973?journal_id=209342021-01-25T00:10:48Zkeith
<ul><li><strong>Subject</strong> changed from <i>SEGV in rate_ctr_add()</i> to <i>NULL m_dl_egprs_ctrs passed to rate_ctr_add()</i></li></ul><pre>
(gdb) up
#1 0x0002f274 in gprs_rlcmac_dl_tbf::create_dl_acked_block (this=this@entry=0x5da078, fn=338684, fn@entry=124215, ts=ts@entry=7 '\a', index=0, index@entry=79, index2=-1)
at /usr/src/debug/osmo-pcu/0.8.0+gitAUTOINC+a100a6bc56-r0.18/git/src/tbf_dl.cpp:837
837 in /usr/src/debug/osmo-pcu/0.8.0+gitAUTOINC+a100a6bc56-r0.18/git/src/tbf_dl.cpp
(gdb) p m_dl_egprs_ctrs
$7 = (rate_ctr_group *) 0x0
(gdb)
</pre> OsmoPCU - Bug #4973: NULL m_dl_egprs_ctrs passed to rate_ctr_add()https://projects.osmocom.org/issues/4973?journal_id=209372021-01-25T04:56:58Zkeith
<ul></ul><p>In case it's relevant, on reviewing the crash again:</p>
<pre>
(gdb) p m_dl_egprs_ctrs
$19 = (rate_ctr_group *) 0x0
(gdb) p m_dl_gprs_ctrs
$20 = (rate_ctr_group *) 0x27ed18
(gdb)
</pre> OsmoPCU - Bug #4973: NULL m_dl_egprs_ctrs passed to rate_ctr_add()https://projects.osmocom.org/issues/4973?journal_id=209442021-01-25T09:38:49Zlaforge
<ul></ul><p>added <a class="user active" href="https://projects.osmocom.org/users/30187">pespin</a> and <a class="user active" href="https://projects.osmocom.org/users/1741">lynxis</a> as watchers</p> OsmoPCU - Bug #4973: NULL m_dl_egprs_ctrs passed to rate_ctr_add()https://projects.osmocom.org/issues/4973?journal_id=209522021-01-25T14:25:45Zpespin
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>Assignee</strong> changed from <i>keith</i> to <i>pespin</i></li></ul> OsmoPCU - Bug #4973: NULL m_dl_egprs_ctrs passed to rate_ctr_add()https://projects.osmocom.org/issues/4973?journal_id=209562021-01-25T17:15:53Zpespin
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Feedback</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>90</i></li></ul><p>I think it should be fixed by this commit, please <a class="user active" href="https://projects.osmocom.org/users/4282">keith</a> give it a try whenever you have some time:</p>
<p><a class="external" href="https://gerrit.osmocom.org/c/osmo-pcu/+/22435">https://gerrit.osmocom.org/c/osmo-pcu/+/22435</a> Fix Dl EGPRS data blocks being generated occasionally on GPRS TBFs</p>
<p>I pushed it now to gerrit together with several other fixes of issues I found while looking at osmo-pcu code.</p> OsmoPCU - Bug #4973: NULL m_dl_egprs_ctrs passed to rate_ctr_add()https://projects.osmocom.org/issues/4973?journal_id=209592021-01-26T04:53:40Zkeith
<ul></ul><p>Certainly seems to have fixed the crash.</p>
<pre>
● osmo-pcu.service - Osmocom osmo-pcu
Loaded: loaded (/lib/systemd/system/osmo-pcu.service; enabled; vendor preset: enabled)
Active: active (running) since Mon 2021-01-25 21:12:33 UTC; 7h ago
Main PID: 3571 (osmo-pcu)
CGroup: /system.slice/osmo-pcu.service
└─3571 /usr/bin/osmo-pcu -c /etc/osmocom/osmo-pcu.cfg
</pre> OsmoPCU - Bug #4973: NULL m_dl_egprs_ctrs passed to rate_ctr_add()https://projects.osmocom.org/issues/4973?journal_id=209662021-01-26T15:55:14Zpespin
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul><p>Fix merged, closing.</p>