Project

General

Profile

Bug #4239

osmo-stp allows RKM de-registration of routing key that never was registered via RKM

Added by laforge almost 2 years ago. Updated 3 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Target version:
-
Start date:
10/21/2019
Due date:
% Done:

100%

Spec Reference:

Description

When an ASP is sending an M3UA RKM DEREG for a routing context/key which was statically configured in the VTY/config, we should not allow for de-registration using RKM. RKM should only de-register routing keys/contexts that were dynamically registered first.

See upcoming STP_Tests_M3UA.TC_rkm_unreg_never_registered

Associated revisions

Revision 1a75755f (diff)
Added by osmith 3 months ago

m3ua: reject deregistration of static routing keys

Make STP_Tests_M3UA.TC_rkm_unreg_never_registered pass.

Closes: OS#4239
Change-Id: Ie5d84d06e7d5d32c8a22f770f71a5449f4a78484

Revision 326d78ed (diff)
Added by osmith 3 months ago

stp: fix TC_rkm_unreg_registered

Create the routing key dynamically, before trying to unregister it. The
previous version tried to unregister a statically configured routing
key, as in TC_rkm_unreg_never_registered, but expected success instead
of the proper ERR_NOT_REG.

So after fixing osmo-stp to make TC_rkm_unreg_never_registered pass,
this test failed.

Related: OS#4239
Change-Id: I7d2f9eb298778a8e60c7e73f314bc73528e85406

Revision ee02223e (diff)
Added by osmith 3 months ago

stp: fix TC_rkm_unreg_active

Create the routing key dynamically, before trying to unregister it, so
osmo-stp doesn't answer with ERR_NOT_REG instead of the expected
ERR_ASP_ACTIVE. While at it, add missing clean up logic.

Related: OS#4239
Change-Id: I31fcba85d23a8767eb0ceb513ff5b440558a475b

Revision 5a3f99c0 (diff)
Added by osmith 2 months ago

stp: rename mp_stp_has_asp_quirk

Rename the option to mp_osmo_stp_newer_than_1_4_0, because I'm going to
use the variable in the next patch for something unrelated to the asp
quirk and so we can avoid introducing another variable.

Related: docker-playground I6a32398242b53c827a94cf65e4a35900a7c4171a
Related: OS#4239
Change-Id: I43b1aa2c029c88c88320d40f60df46a5eb6c4c24

Revision 5af90d11 (diff)
Added by osmith 2 months ago

stp: TC_rkm_unreg_never_registered: !latest

Disable test TC_rkm_unreg_never_registered for current latest version of
osmo-stp (1.4.0), as it does not clean up properly and now causes other
tests to fail.

With this patch, test results for -latest are restored to how it was
before I7d2f9eb298778a8e60c7e73f314bc73528e85406 and
I31fcba85d23a8767eb0ceb513ff5b440558a475b were merged.

Related: OS#4239
Change-Id: Ice8fe9597a0a12eb4ec26172982a0f5cd01a148b

Revision 476e38e4 (diff)
Added by osmith 2 months ago

ttcn3-stp-test: rename mp_stp_has_asp_quirk

Rename the option to mp_osmo_stp_newer_than_1_4_0, because I'm going to
use the variable in an upcoming osmo-ttcn3-hacks.git patch for something
unrelated to the asp quirk so we can avoid introducing another variable.

Related: osmo-ttcn3-hacks I43b1aa2c029c88c88320d40f60df46a5eb6c4c24
Related: OS#4239
Change-Id: I6a32398242b53c827a94cf65e4a35900a7c4171a

History

#1 Updated by laforge 8 months ago

  • Assignee changed from laforge to osmith

#2 Updated by osmith 3 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 90

#3 Updated by osmith 3 months ago

#4 Updated by osmith 3 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)