Project

General

Profile

Actions

Bug #4234

closed

osmo-stp segfaults if IPA client connects to AS with routing-key != 0

Added by laforge almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
Target version:
-
Start date:
10/18/2019
Due date:
% Done:

100%

Spec Reference:

Description

When using something like this

 as mahlzeit ipa
  routing-key 1005 5

and then connecting an IPA client, we crash in ipa_asp_fsm_wait_id_ack2() which contains an OSMO_ASSERT(as). The assert fails as we look-up the assert with a static routing-context of '0' (IPA doesn't allow us to transport a routing context in the message), which fails.

This is similar to #4233

The proper solution is probably to prevent the user from ever configuring a non-zero routing context for IPA AS.


Related issues

Has duplicate OsmoSTP - Bug #4233: osmo-stp segfaults if IPA client with unknown unit_name attachesClosedlaforge10/18/2019

Actions
Actions #1

Updated by laforge almost 3 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 50

With the below patch, VTY now only permits routing-context 0 for IPA peers
https://gerrit.osmocom.org/c/libosmo-sccp/+/15815

Actions #2

Updated by laforge almost 3 years ago

https://gerrit.osmocom.org/c/libosmo-sccp/+/15816 adds some related comments to the code.

Actions #3

Updated by laforge almost 3 years ago

  • Has duplicate Bug #4233: osmo-stp segfaults if IPA client with unknown unit_name attaches added
Actions #4

Updated by laforge almost 3 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 100

patch merged

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)