Bug #4234
osmo-stp segfaults if IPA client connects to AS with routing-key != 0
Start date:
10/18/2019
Due date:
% Done:
100%
Spec Reference:
Description
When using something like this
as mahlzeit ipa routing-key 1005 5
and then connecting an IPA client, we crash in
ipa_asp_fsm_wait_id_ack2() which contains an OSMO_ASSERT(as). The assert fails as we look-up the assert with a static routing-context of '0' (IPA doesn't allow us to transport a routing context in the message), which fails.
This is similar to #4233
The proper solution is probably to prevent the user from ever configuring a non-zero routing context for IPA AS.
Related issues
Associated revisions
History
#1 Updated by laforge almost 2 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 50
With the below patch, VTY now only permits routing-context 0 for IPA peers
https://gerrit.osmocom.org/c/libosmo-sccp/+/15815
#2 Updated by laforge almost 2 years ago
https://gerrit.osmocom.org/c/libosmo-sccp/+/15816 adds some related comments to the code.
#3 Updated by laforge almost 2 years ago
- Has duplicate Bug #4233: osmo-stp segfaults if IPA client with unknown unit_name attaches added
#4 Updated by laforge almost 2 years ago
- Status changed from In Progress to Resolved
- % Done changed from 50 to 100
patch merged
Don't permit routing-context != 0 for IPA peers
The IPA protocol doesn't have the context of routing-keys. We are only
permitting routing key '0' (as the default routing key) when configuring
via VTY.
Change-Id: I3f166f44903d0b93963cc5d0cca73d277d2b7215
Fixes: OS#4234, OS#4233