Bug #4113: osmo-bsc fails to compile on openSUSE Tumbleweed (gcc 9.1 with LTO enabled) - OsmoBSC - Open Source Mobile Communications

Actions

Copy link

Bug #4113

closed

osmo-bsc fails to compile on openSUSE Tumbleweed (gcc 9.1 with LTO enabled)

Added by roox over 4 years ago. Updated almost 4 years ago.

Status:

Resolved

Priority:

High

Assignee:

Hoernchen

Category:

Target version:

Start date:

07/17/2019

Due date:

% Done:

Spec Reference:

Description

openSUSE just enabled LTO by default for its packages in Tumbleweed/Factory.
https://lists.opensuse.org/opensuse-factory/2019-07/msg00240.html
https://gcc.gnu.org/wiki/LinkTimeOptimization

This means the distro provided CFLAGS now changed from

without LTO

CFLAGS='-O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection  -g'

with LTO enabled

CFLAGS="-O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -flto=4 -g -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess"

compiling osmo-bsc master then triggers the following warnings/errors:

[   22s] bsc_init.c:242:16: error: potential null pointer dereference [-Werror=null-dereference]
[   22s] system_information.c:490:9: error: 'f0' may be used uninitialized in this function [-Werror=maybe-uninitialized]
[   22s] lto-wrapper: fatal error: make returned 2 exit status
[   22s] /usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: error: lto-wrapper failed
[   22s] collect2: error: ld returned 1 exit status
[   22s] error: Bad exit status from /var/tmp/rpm-tmp.gBd6u2 (%build)

I have attatched the full buildlog.

Files

osmo-bsc-openSUSE-Tumbleweed-gcc9-LTO-enabled-buildlog.txt

32 KB

buildlog

roox, 07/17/2019 09:48 PM

Related issues

Actions

Copy link

Updated by laforge over 4 years ago

Project changed from Cellular Network Infrastructure to OsmoBSC
Assignee set to Hoernchen
Priority changed from Normal to High

Actions

Copy link

Updated by laforge over 4 years ago

Related to Bug #4114: osmo-ggsn fails to compile on openSUSE Tumbleweed (gcc 9.1 with LTO enabled) added

Actions

Copy link

Updated by laforge over 4 years ago

Related to Bug #4115: osmo-msc fails to compile on openSUSE Tumbleweed (gcc 9.1 with LTO enabled) added

Actions

Copy link

Updated by laforge over 4 years ago

Related to Bug #4112: OpenBSC fails to compile on openSUSE Tumbleweed (gcc 9.1 with LTO enabled) added

Actions

Copy link

Updated by laforge over 4 years ago

Related to Bug #4116: osmo-sgsn fails to compile on openSUSE Tumbleweed (gcc 9.1 with LTO enabled) added

Actions

Copy link

Updated by Hoernchen over 4 years ago

The breakage is actually our own fault, we've had the werror in our configure for a long time, it's just that gcc will only do interprocedural analysis with lto:

grep -riIl "error=null" | grep \.ac$ | xargs grep null-deref
osmo-bsc/configure.ac:AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"])
osmo-sgsn/configure.ac:AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"])
osmo-msc/configure.ac:AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"])
osmo-mgw/configure.ac:AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"])

Actions

Copy link

Updated by Hoernchen over 4 years ago

I guess it's a bit early for LTO anyway, since it breaks function wrapping, which is used in our tests, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88643

Actions

Copy link

Updated by Hoernchen over 4 years ago

And LTO will kill any chance at ever using pragmas to influence warnings and errors, as confirmed by https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80922

Actions

Copy link