Feature #4081
closedAdd dissector for OsmoTRX protocol
90%
Description
- TRXD (v0, v1)
*TRXC
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14814
https://code.wireshark.org/review/#/c/26796/
Files
Checklist
- OsmoTRX: support filtering TRXC and TRXD protocols (osmo_trxd and osmo_trxc)
- OsmoTRXD: support filtering by direction (Rx or Tx bursts)
- OsmoTRXD: fix handling of NOPE indications
- OsmoTRXD: verify the burst length (using modulation type)
- OsmoTRXD: handle optional padding for Rx bursts
- OsmoTRXC: introduce a 'string_string' array for 'CMD', 'RSP' and 'IND'
- OsmoTRXC: enrich the protocol column with message type and verb
- OsmoTRX: make port numbers configurable in the protocol preferences
Related issues
Updated by pespin almost 5 years ago
laforge I assigned it to you since you wrote the initial patches. Feel free to re-assign it to me if you want me to spend time on it.
Updated by laforge over 4 years ago
Not sure if he has time, but fixeria is probably best qualified as he's just re-designing/re-writing the TRX protocol.
Updated by laforge over 4 years ago
- Status changed from New to In Progress
- Assignee changed from laforge to fixeria
Updated by fixeria over 4 years ago
- Checklist item OsmoTRX: support filtering TRXC and TRXD protocols (osmo_trx.data and osmo_trx.ctrl) added
- Checklist item OsmoTRXD: support filtering by direction (Rx or Tx bursts) added
- Checklist item OsmoTRXD: fix handling of NOPE indications added
- Checklist item OsmoTRXD: verify the burst length (using modulation type) added
- Checklist item OsmoTRXD: handle optional padding for Rx bursts added
- Checklist item OsmoTRXC: introduce a 'string_string' array for 'CMD', 'RSP' and 'IND' added
- Checklist item OsmoTRXC: enrich the protocol column with message type and verb added
- File osmo_trx_capture.pcapng.gz osmo_trx_capture.pcapng.gz added
- Category set to TRX Interface
- % Done changed from 0 to 80
I just uploaded a new patch. This is not the final version, but much closer now. The dissector for OsmoTRXD (Data protocol, Rx / Tx bursts) is more or less complete. One missing thing is the ability to filter bursts by direction. Also (just discovered), handling of NOPE indications is broken. The dissector for OsmoTRXC (Clock & Control) still needs some improvements, but in general it works.
https://code.wireshark.org/review/#/c/26796/
Attached a capture file that I am using for testing.
Updated by fixeria over 4 years ago
- Checklist item OsmoTRX: make port numbers configurable in the protocol preferences added
Updated by fixeria over 4 years ago
- Checklist item changed from OsmoTRX: support filtering TRXC and TRXD protocols (osmo_trx.data and osmo_trx.ctrl) to OsmoTRX: support filtering TRXC and TRXD protocols (osmo_trxd and osmo_trxc)
- Checklist item OsmoTRX: support filtering TRXC and TRXD protocols (osmo_trxd and osmo_trxc) set to Done
- Checklist item OsmoTRXD: support filtering by direction (Rx or Tx bursts) set to Done
- Checklist item OsmoTRXD: fix handling of NOPE indications set to Done
- Checklist item OsmoTRXD: handle optional padding for Rx bursts set to Done
- % Done changed from 80 to 90
A new version has been uploaded.
Updated by fixeria over 4 years ago
- Related to Feature #4006: TRX protocol: wind of change added
Updated by fixeria over 4 years ago
- Checklist item OsmoTRXC: introduce a 'string_string' array for 'CMD', 'RSP' and 'IND' set to Done
- Checklist item OsmoTRXC: enrich the protocol column with message type and verb set to Done
Updated by fixeria over 4 years ago
- Checklist item OsmoTRX: make port numbers configurable in the protocol preferences set to Done
OsmoTRX: make port numbers configurable in the protocol preferences
As it turns out, Wireshark adds some protocol preferences automatically.
Updated by fixeria over 4 years ago
- Status changed from In Progress to Feedback
I think I am done. laforge, pespin, please see the latest patch version.
https://code.wireshark.org/review/#/c/26796/16/
OsmoTRXD: verify the burst length (using modulation type)
This check can be implemented later if needed.
Updated by fixeria over 4 years ago
- Status changed from Feedback to Resolved
The patch has finally landed to Wireshark, enjoy!
laforge as you're the reporter of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14814, feel free to close it now.