Project

General

Profile

Bug #3701

rate_ctr_group_alloc() may return NULL if a rate counter group name is not up to specifications; make sure all callers handle that.

Added by neels 6 months ago. Updated 11 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
11/20/2018
Due date:
% Done:

100%

Spec Reference:

Description

At least libosmo-mgcp/mgcp_protocol.c has various invocations of rate_ctr_group_alloc() that ignore the possibility that the name might be wrong and the function would return NULL then.
There should be checks for each invocation; if we some day choose to change the names and/or the rules for names, the code should warn about it instead of segfaulting randomly.
grep for rate_ctr_group_alloc() in the code base and make sure each caller can handle a NULL return value in a sane way.

History

#2 Updated by laforge 12 days ago

  • Assignee set to laforge

#3 Updated by laforge 12 days ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 80

searched through all our repositories and submitted some related fixes to gerrit:

#4 Updated by laforge 11 days ago

  • Status changed from In Progress to Resolved
  • % Done changed from 80 to 100

patches merged

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)