Project

General

Profile

Bug #3551

A few projects still set up .tarball-version incorrectly in debian/rules

Added by pespin 11 days ago. Updated 5 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
09/13/2018
Due date:
% Done:

100%

Estimated time:
Spec Reference:

Description

From libosmo-sccp:

commit c3b1f636c94c01bf190713e2d17e2ffd1a58be9a
Author: Harald Welte <laforge@gnumonks.org>
Date:   Mon Aug 6 11:12:33 2018 +0200

    debian/rules: Don't overwrite .tarball-version

    The .tarball-version file should contain the *source version* uniquely
    identifying the git commit, and not the Debian package name.

    With https://gerrit.osmocom.org/#/c/osmo-ci/+/10343/ there is a correct
    .tarball-version file in the .tar.xz of the nightly source packages.

    Change-Id: I620c96eb311be6fdd4187bdcc311ea893ad93614
    Related: OS#3449

diff --git a/debian/rules b/debian/rules
index 279568f..bea0a76 100755
--- a/debian/rules
+++ b/debian/rules
@@ -23,10 +23,6 @@ override_dh_install:
 override_dh_auto_test:
        dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false)

-override_dh_autoreconf:
-       echo $(VERSION) > .tarball-version
-       dh_autoreconf
-
 override_dh_auto_configure:
        dh_auto_configure -- --enable-static

$ ag tarball-version | grep debian/rules
libsmpp34/debian/rules:18:      echo $(VERSION) > .tarball-version
libgtpnl/debian/rules:29:       echo $(VERSION) > .tarball-version
libusrp/debian/rules:16:        echo $(VERSION) > .tarball-version
libusrp/debian/rules:28:        rm -f tests/package.m4 tests/testsuite .version .tarball-version
osmocom-bb/src/shared/libosmocore/debian/rules:23:      echo $(VERSION) > .tarball-version
libasn1c/debian/rules:51:       echo $(VERSION) > .tarball-version
openbsc/debian/rules:27:        echo $(VERSION) > openbsc/.tarball-version

Related issues

Related to Cellular Network Infrastructure - Bug #3449: network:osmocom:nightly packages have VERSION="UNKNOWN"Resolved2018-08-06

History

#1 Updated by pespin 7 days ago

  • Related to Bug #3449: network:osmocom:nightly packages have VERSION="UNKNOWN" added

#2 Updated by pespin 7 days ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 90

Patches submitted with commit title "debian/rules: Don't overwrite .tarball-version" to the projects listed above in original description.

#3 Updated by pespin 5 days ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 100

Merged, closing

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)