Project

General

Profile

Bug #3432

MSISDN of subscriber can be added/set, but never removed

Added by laforge 3 months ago. Updated about 2 months ago.

Status:
New
Priority:
Normal
Assignee:
Target version:
-
Start date:
07/29/2018
Due date:
% Done:

0%


Description

There's a VTY command to add/update the MSISDN of a subscriber, but currently no way to remove the MSISDN of a subscriber once it has been set.

Something like "subscriber (imsi|msisdn|id) IDENT update msisdn none" would be logical compared to the aud2g/aud3g syntax. However, I don't think the VTY parser can deal with choosing between "none" and the free-form string MSSIDN :(

More general VTY logic would be "no subscriber (imsi|msisdn|id) IDENT msisdn", even though the VTY doesn't seem to implement any "no ..." commands at this point.

History

#1 Updated by neels about 2 months ago

The DEFUN in osmo-hlr/src/hlr_vty_subscr.c could interpret the MSISDN argument of 'none' as removing.

We can try syntax 'subscriber (imsi|msisdn|id) IDENT update msisdn (MSISDN|none)', and if this doesn't get parsed we can simply add this info in the MSISDN argument's doc?

I would also agree with adding 'no ...' commands, but then probably for all the other removal commands as well. Personally, I avoid(ed) the 'no' syntax because in live telnet sessions I dislike having to jump to the start of the line to edit (when re-using from the command history to remove a prev value), I rather arrow-up and edit the end of the line; i.e. just mild personal preference, no evangelism.

#2 Updated by laforge about 2 months ago

Hi Neels,

On Mon, Aug 20, 2018 at 10:08:36AM +0000, neels [REDMINE] wrote:

I would also agree with adding 'no ...' commands, but then probably for all the other removal commands as well. Personally, I avoid(ed) the 'no' syntax because in live telnet sessions I dislike having to jump to the start of the line to edit (when re-using from the command history to remove a prev value), I rather arrow-up and edit the end of the line; i.e. just mild personal preference, no evangelism.

the start of the line is only one ctrl+a away...

This question is mainly one about consistency of user interfaces, and
the VTY style interfaces have the "no ..." syntax well established. at
least tens of thousands of network admins around the world are familiar
with it.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)