Project

General

Profile

Bug #3361

VTY option codec-support is not used

Added by dexter 3 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
06/28/2018
Due date:
% Done:

100%

Estimated time:
Spec Reference:

Description

osmo-bts has per-bts codec support flags, which are stored in struct bts_codec_conf *codec

The vty option codec-support sets those flags:
codec->hr
codec->efr
codec->amr

But the flags seem not to be used anywhere. In osmo_bsc_bssap.c osmo-bts decides for a codec depending on what the MS and the MSC offer. We should include those flags here as well.

History

#1 Updated by dexter 3 months ago

struct gsm_bts->struct bts_codec_conf codec appears in the following locations:

include/osmocom/bsc/gsm_data.h (declaration)
src/osmo-bsc/bsc_vty.c (Sets configuration)
src/osmo-bsc/handover_decision_2.c (used by find_alternative_lchan())
tests/handover/handover_test.c (Sets some test values)

So we use those settings when we make the handover decision, but not when we do the assignment. Technically this would mean that we use gsm_bts->struct bts_codec_conf codec to restrict the values we have set up globally for the BSC in struct bsc_msc_data->struct gsm_audio_support audio_support even further.

#2 Updated by dexter 2 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 90

I have extended the unit-test so that they test the codec selection function that does all the intersection stuff. Then I integrated the codec-support flags into the decision. I will push the patch set later today.

#3 Updated by dexter 2 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

Patch set has been merged, see also: https://gerrit.osmocom.org/#/c/osmo-bsc/+/10011/

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)