Project

General

Profile

Actions

Bug #2521

closed

reduce levels in struct mgcp_conn_rtp

Added by dexter over 6 years ago. Updated over 4 years ago.

Status:
Rejected
Priority:
Low
Assignee:
Category:
-
Target version:
-
Start date:
09/25/2017
Due date:
% Done:

0%

Spec Reference:

Description

See struct mgcp_conn_rtp in mgcp_internal.h. Struct member struct mgcp_rtp_end end could be eliminated by putting all struct members from struct mgcp_rtp_end to struct mgcp_conn_rtp. This would reduce one level when dereferencing the pointers. The code would become more readable.

Actions #1

Updated by laforge over 6 years ago

Actions #2

Updated by laforge over 6 years ago

  • Priority changed from Normal to Low
Actions #3

Updated by dexter almost 6 years ago

I had another look into this, but I see a problem. If we merge the structs we would also have to merge a lot more since struct mgcp_conn_rtp acts as an umbrellla for a lot of structs.

For example there is still:
struct mgcp_rtp_state state;
struct mgcp_rtp_tap tap_in;
struct mgcp_rtp_tap tap_out;

Actions #4

Updated by dexter over 4 years ago

  • Status changed from New to Rejected
Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)