Project

General

Profile

Actions

Bug #2284

closed

osmo-gsm-tester resource error does not result in test failure, and other reporting issues

Added by neels almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Target version:
-
Start date:
05/22/2017
Due date:
% Done:

0%

Spec Reference:

Description

When I launch a trial and it aborts due to insufficient resources, I get a return code of zero.
pespin, this is due to your recent junit patch. More details in comment...
http://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_run-aoip/5/

Actions #1

Updated by neels almost 7 years ago

http://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_run-aoip/5/

22:10:16 tst                          trial-5: Trial start
22:10:16 tst                          trial-5: Detailed log at /home/jenkins/workspace/osmo-gsm-tester_run-aoip/trial-5/run.2017-05-22_22-10-16/log
------------------------------------------
trial-5 aoip_sms:sysmo
------------------------------------------
22:10:16 tst                   aoip_sms:sysmo: Suite run start
22:10:16 tst                   aoip_sms:sysmo: reserving resources in /var/tmp/osmo-gsm-tester/state ...
22:10:16 tst                   aoip_sms:sysmo: Reserving 1 x bts (candidates: 1)
22:10:16 tst                          trial-5: Trial end
22:10:16 tst                   aoip_sms:sysmo: ERR: NoResourceExn: No matching resource available for bts = {'type': 'osmo-bts-sysmo'}
------------------------------------------
All trials passed:

------------------------------------------
+ exit_code=0

The result XML is empty. Also note that the log file in the trial-5-run.tgz does not include the resource error, possibly because the exception handling is done outside of the 'with trial' scope.

Despite the long review, I didn't catch these important problems... Please fix! And please test the various failures, making sure the results make sense:

  • nonzero exit code
  • XML result errors
  • No omissions in run.*/log

For

  • exception during a test,
  • exception during resource reservation,
  • exception while trying to use more resources than were reserved.

BTW I also noticed two result XMLs in a different (manual) run; make sure you don't call Dir.new_child() twice, it creates a unique file name every time.

Actions #2

Updated by pespin almost 7 years ago

  • Assignee changed from pespin to neels
As discussed with Neels:
Actions #3

Updated by neels almost 7 years ago

I will take a look at the scoping details

Actions #4

Updated by neels almost 7 years ago

(still on the to-do list)

Actions #5

Updated by pespin almost 7 years ago

Neels, I think this is done already right?

Actions #6

Updated by neels almost 7 years ago

  • Status changed from New to Resolved
Actions #7

Updated by laforge over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)