Bug #2284
closedosmo-gsm-tester resource error does not result in test failure, and other reporting issues
0%
Description
When I launch a trial and it aborts due to insufficient resources, I get a return code of zero.
pespin, this is due to your recent junit patch. More details in comment...
http://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_run-aoip/5/
Updated by neels almost 7 years ago
http://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_run-aoip/5/
22:10:16 tst trial-5: Trial start 22:10:16 tst trial-5: Detailed log at /home/jenkins/workspace/osmo-gsm-tester_run-aoip/trial-5/run.2017-05-22_22-10-16/log ------------------------------------------ trial-5 aoip_sms:sysmo ------------------------------------------ 22:10:16 tst aoip_sms:sysmo: Suite run start 22:10:16 tst aoip_sms:sysmo: reserving resources in /var/tmp/osmo-gsm-tester/state ... 22:10:16 tst aoip_sms:sysmo: Reserving 1 x bts (candidates: 1) 22:10:16 tst trial-5: Trial end 22:10:16 tst aoip_sms:sysmo: ERR: NoResourceExn: No matching resource available for bts = {'type': 'osmo-bts-sysmo'} ------------------------------------------ All trials passed: ------------------------------------------ + exit_code=0
The result XML is empty. Also note that the log file in the trial-5-run.tgz does not include the resource error, possibly because the exception handling is done outside of the 'with trial' scope.
Despite the long review, I didn't catch these important problems... Please fix! And please test the various failures, making sure the results make sense:
- nonzero exit code
- XML result errors
- No omissions in run.*/log
For
- exception during a test,
- exception during resource reservation,
- exception while trying to use more resources than were reserved.
BTW I also noticed two result XMLs in a different (manual) run; make sure you don't call Dir.new_child() twice, it creates a unique file name every time.
Updated by pespin almost 7 years ago
- Assignee changed from pespin to neels
- I fixed the exit(1) when an exception is triggered. It is in gerrit: https://gerrit.osmocom.org/#/c/2723/
- I fixed the two result XML file issue: https://gerrit.osmocom.org/#/c/2724/
- Regarding the UNKNOWN status being shown when triggering a CTRL+C or other scenarios, I attempt to fix it in the following branch, but I'm having some trouble with the "with" and "try" parts and the log tracing output: http://git.osmocom.org/osmo-gsm-tester/log/?h=issue-2284
Updated by neels almost 7 years ago
- Status changed from New to Resolved
forgot to update the issue. Solved by https://gerrit.osmocom.org/#/c/2853/ and https://gerrit.osmocom.org/#/c/2886/