Actions
Bug #4334
closedpython3 UnicodeDecodeError in verify_value_string_arrays_are_terminated.py
Start date:
12/17/2019
Due date:
% Done:
100%
Spec Reference:
Description
ERROR: file contains unterminated value_string 'struct value_string change_flags[]': './deps/simtrace2/host/src/simtrace2-sniff.c'
ERROR: file contains unterminated value_string 'struct value_string data_flags[]': './deps/simtrace2/host/src/simtrace2-sniff.c'
Traceback (most recent call last):
File "/build_bin/verify_value_string_arrays_are_terminated.py", line 47, in <module>
check_file(f)
File "/build_bin/verify_value_string_arrays_are_terminated.py", line 30, in check_file
arrays = value_string_array_re.findall(codecs.open(f, "r", "utf-8").read())
File "/usr/lib/python3.5/codecs.py", line 698, in read
return self.reader.read(size)
File "/usr/lib/python3.5/codecs.py", line 501, in read
newchars, decodedbytes = self.decode(data, self.errors)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xb5 in position 336: invalid start byte
Build step 'Execute shell' marked build as failure
[WARNINGS]Skipping publisher since build result is FAILURE
Finished: FAILURE
Sure, there is an actual problem in the value_string arrays, but we should't get that UnicodeDecodeError.
Updated by laforge over 4 years ago
- Subject changed from python3 problem in verify_value_string_arrays_are_terminated.py to python3 UnicodeDecodeError in verify_value_string_arrays_are_terminated.py
Slightly related: https://gerrit.osmocom.org/c/simtrace2/+/16635 fixes the actual value_string[] formatting (the termination was there). Nevertheless, this bug is about the UnicodeDecodeError
Updated by laforge over 4 years ago
Traceback (most recent call last):
File "/build_bin/verify_value_string_arrays_are_terminated.py", line 47, in <module>
check_file(f)
File "/build_bin/verify_value_string_arrays_are_terminated.py", line 30, in check_file
arrays = value_string_array_re.findall(codecs.open(f, "r", "utf-8").read())
File "/usr/lib/python3.5/codecs.py", line 698, in read
return self.reader.read(size)
File "/usr/lib/python3.5/codecs.py", line 501, in read
newchars, decodedbytes = self.decode(data, self.errors)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xb5 in position 11275: invalid start byte
Updated by laforge over 4 years ago
- Status changed from New to In Progress
- Assignee changed from osmith to laforge
- % Done changed from 0 to 70
It's becoming too much of a blocker for making progess in merging osmo-remsim changes - https://gerrit.osmocom.org/c/osmo-ci/+/16638
Updated by laforge over 4 years ago
- Status changed from In Progress to Resolved
- % Done changed from 70 to 100
patch merged
Actions
