https://projects.osmocom.org/https://projects.osmocom.org/favicon.ico?16647414092019-06-07T20:14:12ZOpen Source Mobile CommunicationsOsmoPCU - Bug #4052: Test uncompressed bitmaps without lengthhttps://projects.osmocom.org/issues/4052?journal_id=147702019-06-07T20:14:12Zlynxis
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-high2 closed" href="/issues/3728">Bug #3728</a>: Problem using compressed ACK/NACK bitmaps or uncompressed bitmaps without length</i> added</li></ul> OsmoPCU - Bug #4052: Test uncompressed bitmaps without lengthhttps://projects.osmocom.org/issues/4052?journal_id=147722019-06-07T20:16:43Zlynxis
<ul><li><strong>Assignee</strong> set to <i>lynxis</i></li></ul> OsmoPCU - Bug #4052: Test uncompressed bitmaps without lengthhttps://projects.osmocom.org/issues/4052?journal_id=147732019-06-07T20:20:15Zlynxis
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>Urgent</i></li></ul> OsmoPCU - Bug #4052: Test uncompressed bitmaps without lengthhttps://projects.osmocom.org/issues/4052?journal_id=148362019-06-16T17:28:24Zlynxis
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>20</i></li></ul><p><del>There is at least one corner cases, which I'ven't found in the 44.060: What happens when an EGPRS ACK/NACK does not have a Length field, but the uncompressed RBB is less the remaining rest_bits? This was possible, when less than 8 bits were remaining, so only happens when having huge packet loss.</del></p>
<p>... This is defined as spec compliant. Out of window bits should be ignored.</p>
<p>I've implemented a fix for this in my branch lynxis/gprs-ack-nack <a class="external" href="https://gerrit.osmocom.org/plugins/gitiles/osmo-pcu/+/lynxis/gprs-ack-nack">https://gerrit.osmocom.org/plugins/gitiles/osmo-pcu/+/lynxis/gprs-ack-nack</a><br />I will push this patch to gerrit and write test cases for the encoding.</p>
<p>However I want also validate the encoding of the URBB is correct at all.</p> OsmoPCU - Bug #4052: Test uncompressed bitmaps without lengthhttps://projects.osmocom.org/issues/4052?journal_id=148372019-06-16T17:32:33Zlynxis
<ul><li><strong>Spec Reference</strong> set to <i>44.060</i></li></ul> OsmoPCU - Bug #4052: Test uncompressed bitmaps without lengthhttps://projects.osmocom.org/issues/4052?journal_id=148382019-06-17T00:29:47Zlynxis
<ul></ul><p>lynxis wrote:</p>
<blockquote>
<p>There is at least one corner cases, which I'ven't found in the 44.060: What happens when an EGPRS ACK/NACK does not have a Length field, but the uncompressed RBB is less the remaining rest_bits? This was possible, when less than 8 bits were remaining, so only happens when having huge packet loss.</p>
<p>... This is defined as spec compliant. Out of window bits should be ignored.</p>
</blockquote>
<p>But those bits are still <b>within</b> the window. They won't be ignored. And bits which represent V(R) or higher must be set to 0 (44.060 9.1.10).</p> OsmoPCU - Bug #4052: Test uncompressed bitmaps without lengthhttps://projects.osmocom.org/issues/4052?journal_id=151072019-07-10T14:31:15Zlynxis
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Feedback</i></li><li><strong>% Done</strong> changed from <i>20</i> to <i>90</i></li></ul><p>The uncompressed bitmap will be removed.</p>
<p><a class="external" href="https://gerrit.osmocom.org/c/osmo-pcu/+/14697">https://gerrit.osmocom.org/c/osmo-pcu/+/14697</a></p> OsmoPCU - Bug #4052: Test uncompressed bitmaps without lengthhttps://projects.osmocom.org/issues/4052?journal_id=151822019-07-17T14:06:34Zlynxis
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul><p>The patch is now merged.</p>