Project

General

Profile

Bug #3955

OsmoSGSN LLC implementation maintains XID state in LLME (MS) and not per LLE

Added by laforge 26 days ago. Updated 19 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
04/24/2019
Due date:
% Done:

100%

Spec Reference:

Description

For every logical session between a MS and the SGSN, there is one LLME (LLC Management Entity) and a set of LLEs (Logical Link Entities): One for each SAPI.

The XID procedure used to establish LLC configuration values such as N201 (MTU) parameters happens on each LLE separately. The negotiated parameters only affect that one LLE (SAPI) and are not global.

Still, the OsmoSGSN LLC code has the "struct llist_head *xid" member as part of the gprs_llc_llme, and not as part of the gprs_llc_lle. This list is a cahce of the XID fields we have sent with the last XID request, which is used in processing the resposne from the MS.

If two XID handshakes were to occurr concurrently on two LLEs, the state between them would get messed up. It must be maintained separately for each LLE.

History

#1 Updated by laforge 26 days ago

  • % Done changed from 0 to 80

#2 Updated by laforge 19 days ago

  • Status changed from In Progress to Resolved
  • % Done changed from 80 to 100

patch merged

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)