Bug #3791
closedOsmoBTS doesn't include the "IPA Destination IP Address" attribute in "IPA RSL Connect ACK"
100%
Description
Unlike a nanoBTS, OsmoBTS doesn't return the "IPA Destination IP Address" attribute in "IPA RSL Connect ACK" in response to a "IPA RSL Connect"
Related issues
Updated by laforge about 5 years ago
- Related to Feature #2469: Proper OML MO (managed object) using osmo_fsm added
Updated by fixeria about 3 years ago
As far as I can see, osmo-bts does reuse the received message buffer by changing the message type and sending it back. Thus if the IPA RSL Connect does not connect the Destination IP Address, then the ACK would not contain it too. So do we want to have this attribute in the ACK regardless of its presence in the request?
Updated by fixeria about 3 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 80
remote: https://gerrit.osmocom.org/c/osmo-bts/+/22760 oml: cosmetic code style changes in rx_oml_ipa_rsl_connect() [NEW]
remote: https://gerrit.osmocom.org/c/osmo-bts/+/22761 oml: avoid redundant ntohl() / htonl() conversion [NEW]
remote: https://gerrit.osmocom.org/c/osmo-bts/+/22762 oml: make 'struct tlv_parsed' pointer const where possible [NEW]
remote: https://gerrit.osmocom.org/c/osmo-bts/+/22763 oml: reuse the given msgb in oml_fom_ack_nack() [NEW]
remote: https://gerrit.osmocom.org/c/osmo-bts/+/22764 oml: use regular TLVP_PRES() in rx_oml_ipa_rsl_connect() [NEW]
remote: https://gerrit.osmocom.org/c/osmo-bts/+/22765 oml: ensure that IPA RSL Connect ACK/NACK contains all IEs [NEW]
Updated by laforge about 3 years ago
On Sat, Feb 06, 2021 at 01:35:18PM +0000, fixeria [REDMINE] wrote:
As far as I can see, osmo-bts does reuse the received message buffer by changing the message type and sending it back. Thus if the IPA RSL Connect does not connect the Destination IP Address, then the ACK would not contain it too. So do we want to have this attribute in the ACK regardless of its presence in the request?
yes, it should basically confirm the actual address RSL has connected to.
Updated by laforge about 3 years ago
- Status changed from Feedback to Resolved
- % Done changed from 80 to 100
patch merged