Project

General

Profile

Actions

Bug #3769

closed

docker-playground: RUN_ARGS in Makefile leads to unexpected behavior

Added by osmith about 5 years ago. Updated about 5 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Target version:
-
Start date:
01/28/2019
Due date:
% Done:

0%

Spec Reference:

Description

While investigating why some ttcn3-foo-test-latest jobs are failing (#3767), I have discovered that many Docker containers in docker-playground.git have additional Docker command-line arguments specified in their Makefile.

This is unexpected, because most Makefiles in that repository only have this line:

include ../make/Makefile

For osmo-msc-master it looks like this:

RUN_ARGS?=--rm --network sigtran --ip 172.18.0.10 -v msc-vol:/data

include ../make/Makefile

It is easy to overlook this, because the expected place for docker run arguments is the jenkins.sh file, e.g. ttcn3-msc-test/jenkins.sh:

...
echo Starting container with MSC
docker run    --rm \
        --network $NET_NAME --ip 172.18.1.10 \
        -v $VOL_BASE_DIR/msc:/data \
        -v $VOL_BASE_DIR/unix:/data/unix \
        --name ${BUILD_TAG}-msc -d \
        $REPO_USER/osmo-msc-$IMAGE_SUFFIX \
        osmo-msc
...

I have seen an error related to not being able to connect to 172.18.*0*.10 (the IP from the Makefile), so I'm assuming that the RUN_ARGS override what we specify in jenkins.sh. Need to look into this more though.


Related issues

Related to Cellular Network Infrastructure - Bug #3767: Most ttcn3-*-test-latest jenkins jobs are failingResolvedosmith01/24/2019

Actions
Actions #1

Updated by osmith about 5 years ago

  • Related to Bug #3767: Most ttcn3-*-test-latest jenkins jobs are failing added
Actions #2

Updated by osmith about 5 years ago

  • Status changed from New to Rejected

These RUN_ARGS do not override the arguments used in jenkins.sh. They would only be used by doing that:

$ cd docker-playground/osmo-msc-master
$ make run

We might want to remove the RUN_ARGS lines anyway for clarity, but I'm not sure if somebody is using make run with the containers. At least we have an issue about it now, if somebody stumbles upon this again.

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)