Project

General

Profile

Bug #3679

bsc_vty.c iterates trx to regen sysinfo manually, skips bcch_change_mark bump

Added by neels almost 2 years ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
10/31/2018
Due date:
% Done:

100%

Spec Reference:

Description

See gsm_bts_set_system_infos() in bsc_init.c, which increments bcch_change_mark.
Compare bts_resend_cmd in bsc_vty.c which does

        llist_for_each_entry_reverse(trx, &bts->trx_list, list)
                gsm_bts_trx_set_system_infos(trx);

and doesn't increment bcch_change_mark.

Does this need fixing?

History

#1 Updated by laforge 4 months ago

  • Status changed from Feedback to In Progress
  • % Done changed from 0 to 70

#2 Updated by neels 4 months ago

related, I'm not sure about this at all, but I now also notice a possible similar problem in bootstrap_rsl() in osmo_bsc_main.c:

static void bootstrap_rsl(struct gsm_bts_trx *trx)
{
[...]
        gsm_bts_trx_set_system_infos(trx);
static int inp_sig_cb(unsigned int subsys, unsigned int signal,
                      void *handler_data, void *signal_data)
{
[...]
        switch (signal) {
        case S_L_INP_TEI_UP:
[...]
                if (isd->link_type == E1INP_SIGN_RSL)
                        bootstrap_rsl(trx);

So whenever a BTS reconnects and brings a TRX up, there is no bcch_change_mark increment,
because this only calls gsm_bts_TRX_set_system_infos() and not gsm_BTS_set_system_infos().
Is that fine?

#3 Updated by laforge 4 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 70 to 100

patch merged

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)