Bug #3674
closed'show rate-counters' VTY command uses ambiguous group titles
0%
Description
The 'show rate-counters' command added in commit 73b7fa61096c69c137bc3a1cbac0a83355cf8b5f shows the name of each counter group. If there are multiple instances of a given counter group, they all share the same description. This makes it hard to tell where the displayed counters belong.
For instance, osmo-mgw maintains RTP statistics per connection, and if more than one connection exists, we get a list of counter groups with no indication which connection the counters belong to:
OsmoMGW> show rate-counters
rtp connection statistics:
stream_err_tstmp:in: 0 (0/s 0/m 0/h 0/d) Inbound rtp-stream timestamp errors.
stream_err_tstmp:out: 0 (0/s 0/m 0/h 0/d) Outbound rtp-stream timestamp errors.
rtp:packets_rx: 3 (0/s 0/m 0/h 0/d) Inbound rtp packets.
rtp:octets_rx: 48 (0/s 0/m 0/h 0/d) Inbound rtp octets.
rtp:packets_tx: 0 (0/s 0/m 0/h 0/d) Outbound rtp packets.
rtp:octets_rx: 0 (0/s 0/m 0/h 0/d) Outbound rtp octets.
rtp:dropped: 0 (0/s 0/m 0/h 0/d) dropped rtp packets.
rtp connection statistics:
stream_err_tstmp:in: 0 (0/s 0/m 0/h 0/d) Inbound rtp-stream timestamp errors.
stream_err_tstmp:out: 0 (0/s 0/m 0/h 0/d) Outbound rtp-stream timestamp errors.
rtp:packets_rx: 0 (0/s 0/m 0/h 0/d) Inbound rtp packets.
rtp:octets_rx: 0 (0/s 0/m 0/h 0/d) Inbound rtp octets.
rtp:packets_tx: 3 (0/s 0/m 0/h 0/d) Outbound rtp packets.
rtp:octets_rx: 48 (0/s 0/m 0/h 0/d) Outbound rtp octets.
rtp:dropped: 0 (0/s 0/m 0/h 0/d) dropped rtp packets.
Updated by stsp over 5 years ago
At a minimum, we can show the group index as well.
See this proposed patch: https://gerrit.osmocom.org/c/libosmocore/+/11503
Updated by stsp over 5 years ago
The above patch has been merged.
Does anyone have suggestions what else could be done for this issue?
Updated by stsp over 5 years ago
- Status changed from In Progress to Resolved
Current solution seems to be good enough for now. Closing this issue.
