Project

General

Profile

Bug #3627

osmo_ortp.c:my_ortp_logfn does not add endline char during log

Added by pespin 3 months ago. Updated 29 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
10/04/2018
Due date:
% Done:

100%

Spec Reference:

Description

During osmo-bts processing, I found the following lines all over the place without endlines, and all are related to osmo_ortp.c:

osmo_ortp.c:0 Sending RTCP SR compound message on session [0x7ffff1728f20].20181003200335480 DMEAS ... whatever here....

That's log output coming fro ortp itself. In order to feed the information into our log system, we use function "my_ortp_logfn".
I'd strlen(fmt), then check if last char is '\n', and otherwise use a new buffer and copy fmt + append '\n'.

History

#1 Updated by pespin about 1 month ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 90

Fixed here:
https://gerrit.osmocom.org/#/c/libosmo-abis/+/11744 osmo_ortp: Log domain and fix strings without endl char

#2 Updated by pespin 29 days ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 100

Merged, closing.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)