Bug #3467
closedtrxcon/sched_clck.c: use CLOCK_MONOTONIC for TDMA frame timer
0%
Description
Hi Stefan,
I was AFK and missed your messages, but now you're offline, so I will answer here.
I've been reading trxcon code today to learn more about how gsm frames are laid out
and how they are processed; the code is a surprisingly great resource for this!
Thanks. I am glad to hear that this code is helpful for other people :)
But it was not written from scratch, some parts are based on the OsmoBTS code,
and this is another great source for learning new things about GSM L1.
I also found what looks like bugs in the clock code: https://paste.apache.org/XgAV
This part of the code is also heavily based on the corresponding part of OsmoBTS,
but in OsmoBTS it was updated: https://gerrit.osmocom.org/3037/, unlike trxcon.
I plan to write patches for this soon, just checking if you agree
Sure, thanks!
I have this task in my personal TODO list, but still have no enough time for that.
So, feel free, I will be happy to review ;)
Updated by stsp over 5 years ago
The code was updated in osmo-bts-trx (https://gerrit.osmocom.org/3037/) but the problematic bit of code was not fixed in that commit, it was just moved.
See https://gerrit.osmocom.org/c/osmo-bts/+/10488 for a related osmo-bts-trx fix.
(Related simply because it's another instance of the same bad time value subtraction pattern).
https://gerrit.osmocom.org/c/osmocom-bb/+/10489 fixes the problem in trxcon.
Updated by stsp over 5 years ago
- Subject changed from trxcon/sched_clck.c: use timerfd and CLOCK_MONOTONIC for TDMA frame timer to trxcon/sched_clck.c: use CLOCK_MONOTONIC for TDMA frame timer
Updated by stsp over 5 years ago
- Status changed from New to Resolved
Above patches have been merged.