Bug #3432
closedMSISDN of subscriber can be added/set, but never removed
0%
Description
There's a VTY command to add/update the MSISDN of a subscriber, but currently no way to remove the MSISDN of a subscriber once it has been set.
Something like "subscriber (imsi|msisdn|id) IDENT update msisdn none" would be logical compared to the aud2g/aud3g syntax. However, I don't think the VTY parser can deal with choosing between "none" and the free-form string MSSIDN :(
More general VTY logic would be "no subscriber (imsi|msisdn|id) IDENT msisdn", even though the VTY doesn't seem to implement any "no ..." commands at this point.
Updated by neels over 5 years ago
The DEFUN in osmo-hlr/src/hlr_vty_subscr.c could interpret the MSISDN argument of 'none' as removing.
We can try syntax 'subscriber (imsi|msisdn|id) IDENT update msisdn (MSISDN|none)', and if this doesn't get parsed we can simply add this info in the MSISDN argument's doc?
I would also agree with adding 'no ...' commands, but then probably for all the other removal commands as well. Personally, I avoid(ed) the 'no' syntax because in live telnet sessions I dislike having to jump to the start of the line to edit (when re-using from the command history to remove a prev value), I rather arrow-up and edit the end of the line; i.e. just mild personal preference, no evangelism.
Updated by laforge over 5 years ago
Hi Neels,
On Mon, Aug 20, 2018 at 10:08:36AM +0000, neels [REDMINE] wrote:
I would also agree with adding 'no ...' commands, but then probably for all the other removal commands as well. Personally, I avoid(ed) the 'no' syntax because in live telnet sessions I dislike having to jump to the start of the line to edit (when re-using from the command history to remove a prev value), I rather arrow-up and edit the end of the line; i.e. just mild personal preference, no evangelism.
the start of the line is only one ctrl+a away...
This question is mainly one about consistency of user interfaces, and
the VTY style interfaces have the "no ..." syntax well established. at
least tens of thousands of network admins around the world are familiar
with it.
Updated by stsp over 5 years ago
- Status changed from In Progress to Resolved
Already implemented by neels in http://git.osmocom.org/osmo-hlr/commit/?id=a820ea1f67bab68136fbaae0108bb90c94b77b22
Updated by neels over 5 years ago
On Mon, Dec 10, 2018 at 02:52:02PM +0000, stsp [REDMINE] wrote:
Already implemented by neels in http://git.osmocom.org/osmo-hlr/commit/?id=a820ea1f67bab68136fbaae0108bb90c94b77b22
quite recently, too, for congress, actually. I thought the POC service wants to
be able to remove an MSISDN (which turned out to be a misunderstanding).
wasn't aware of the issue, sorry...
