Project

General

Profile

Bug #3401

target/firmware/l1ctl: both chan_nr and link_id are not set for L1CTL_DATA_CONF

Added by fixeria over 1 year ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
OsmocomBB Layer 1 (Coding)
Target version:
-
Start date:
07/17/2018
Due date:
% Done:

0%

Resolution:
Spec Reference:

Description

Due to a bit complicated implementation of event handling in the firmware, it's hard to pass all required parameters to an event handler. So, both chan_nr and link_id are not being set (always 0x00) for L1CTL messages of type L1CTL_DATA_CONF. At the same time link_id is checked by the higher layers at 'src/host/layer23/src/common//rx_ph_data_conf()':

/* determine LAPDm entity based on SACCH or not */
if (dl->link_id & 0x40)
        le = &ms->lapdm_channel.lapdm_acch;
else
        le = &ms->lapdm_channel.lapdm_dcch;

/* send it up into LAPDm */
return lapdm_phsap_up(&pp.oph, le);

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)